-
Notifications
You must be signed in to change notification settings - Fork 0
Refine lexicon #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0438730 to
97e3dd0
Compare
a23f30a to
634f158
Compare
da3db55 to
1a7d747
Compare
🟡 Linting WarningsWarnings:
✅ Incompatible ChangesNo breaking changes were detected. ✅ DNSNo DNS issues detected! |
84f0a28 to
4d443d1
Compare
95bca31 to
ac2ae5e
Compare
|
The two "com.germnetwork.declaration: string field with no format or maximum size" lines in the check output above cannot be reproduced on my machine. I think this is a bug in goat, even though I'm running the same version. |
|
I'll endorse not enforcing limits on the size cryptographic material (current key, keyPackage fields). The length of the continuity proofs array though - is not meant as a complete log but as a rolling window, so we can pull it in a few orders of magnitude. Modal occupancy should be 1. 100 is a SWAG at an upper bound, so I'm ok with 1000 here. If we run out of capacity, clients should fail gracefully |
8c284d8 to
242d259
Compare
We should probably also add minLength and maxLength on the byte fields.