Fix Ruff errors #78
Merged
Fix Ruff errors #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Ruff linter errors across the codebase by addressing import ordering, naming conventions, documentation formatting, and code style issues. The changes standardize the code to comply with modern Python linting rules.
Key Changes
- Reordered imports to follow standard conventions (standard library, third-party, local)
- Added
noqacomments for intentional rule violations (e.g., FBT003 for boolean positional arguments, N806 for capitalized variable names, PLR2004 for magic numbers) - Standardized naming in documentation from "Brooks–Corey" to "Brooks and Corey" and "Van Genuchten–Mualem" to "Van Genuchten"
- Replaced en-dashes with hyphens in citations for ASCII compatibility
- Removed Spanish comments from example files
- Updated
typing.Sequencetocollections.abc.Sequencefor Python 3.9+ compatibility
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_solve.py | Import reordering, reference citation formatting, removed pytest.importorskip for fronts module |
| tests/test_neural/test_validity/test_vangenuchten.py | Import reordering, added noqa comments for magic numbers |
| tests/test_neural/test_validity/test_letd.py | Import reordering, added noqa comments for magic numbers |
| tests/test_neural/test_grenoblesand.py | Import reordering, added noqa comments for variable naming and boolean positional args |
| tests/test_neural/test_exact.py | Import reordering, added blank line and noqa comments |
| tests/test_inverse.py | Updated reference citations with hyphens instead of en-dashes |
| tests/test_finite.py | Removed unreferenced References section |
| src/frontx/models.py | Simplified module docstring, updated "Brooks–Corey" to "Brooks and Corey" |
| src/frontx/finite.py | Updated documentation text, removed all export list, removed blank line |
| src/frontx/examples/validity.py | Removed Spanish comments, updated imports, standardized naming |
| src/frontx/examples/neural/validity/vangenuchten.py | Removed ruff directive, added noqa comments, updated documentation |
| src/frontx/examples/neural/validity/letd.py | Removed ruff directive and unused import, added noqa comments |
| src/frontx/examples/neural/grenoblesand.py | Import reordering, added noqa comments, updated formatting |
| src/frontx/examples/neural/exact.py | Removed ruff directive comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.