Modified CMakeLists to support building shared or static libraries #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a chance this can be merged? I'd rather not have to pull changes from a PR and have the latest changes be reflected on the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified CMakeLists.txt to support the standard CMake build option BUILD_SHARED_LIBS=ON/OFF.
This allows the user to select desired library type via a standard method at configuration time (needed if static linking libmaxflow to a project). There is not currently a convenient way to set this without manually changing line 59 in CMakeLists.txt from SHARED to STATIC.
This change does not affect the default behavior of the package.