Conversation
baselqyqony
commented
Jul 8, 2021
baselqyqony
commented
- add TestUDPUsingSchedular test to ProfilerTest
gerazo
left a comment
gerazo
left a comment
There was a problem hiding this comment.
This tricky failure needs testing. It can happen that you run 100 times and only once it fails. For this, you can write a simple script.
| #include <cstdio> | ||
| #include <thread> | ||
|
|
||
| #include "gtest/gtest.h" |
There was a problem hiding this comment.
Putting the test headers in front of anything else does make sense in this case.
test/ProfilerTest.cpp
Outdated
| !packet_to_process.IsEmpty(); packet_to_process = pc.Poll()) { | ||
| } | ||
| // test receiving data | ||
| EXPECT_EQ(Receive(), true); |
There was a problem hiding this comment.
This line fails in clang release (returns false). It would be good to find out, why.
|
The last one could trigger the same problem also in Debug. This means that clang, the compiler does something different which causes this problem. |
…ecieved bytes are different
|
I found the problem root cause, in the release on clang phase the buffer has different values from the expected ones, because of that the function receives returns false |
|
Thank @baselqyqony nice catch. I will look into it. I am creating an issue. |
2 participants
