chore: drop grunt, jshint -> eslint, ESM in tests#30
Open
brettz9 wants to merge 1 commit intogeraintluff:masterfrom
Open
chore: drop grunt, jshint -> eslint, ESM in tests#30brettz9 wants to merge 1 commit intogeraintluff:masterfrom
brettz9 wants to merge 1 commit intogeraintluff:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2 .
This PR moves away from Grunt to
package.jsonscripts as per most current projects' practices.It also switches jshint to the more widely used eslint.
The switch to ESM in tests necessitated redefining
__dirnamewhich is not present by default in modules (and where importing of JSON is only supported by the latest Node versions). There were also a couple unused variables I removed to handle linting errors.The tests are still passing if you run
npm run mocha, butnpm testis currently failing as it depends on eslint passing, and there are some linting errors in the mainsrcfile which still need to be fixed (ESLint's recommended config is more strict about certain things). I plan to do this in a separate PR, allowing this PR to have less noise and focus more on the chores.Please let me know your preferences for PRs (e.g., if you don't care about having PRs for minor chores).