Open
Conversation
notReallyPercentEncode was ignoring double encoded things that ended with a letter.
|
Why not |
Author
|
This function is trying to undo percent encoded stuff that got percent encoded again. So the regex is meant to match things that are are percent encoded (start with the % character) followed by the hexadecimal value for percent (25), followed by a hexadecimal ascii character [0-9][0-9a-fA-F]. I am not sure if it makes a difference if you allow [0-9a-fA-F] on the first character, but the [0-9] should match a character that has been encoded. It would probably be even better to only match the hexadecimal of characters that get encoded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notReallyPercentEncode was ignoring double encoded things that ended with a letter.