Skip to content

Comments

extract options FFI#247

Merged
michaelkirk merged 2 commits intomainfrom
mkirk/options-logic
Feb 6, 2026
Merged

extract options FFI#247
michaelkirk merged 2 commits intomainfrom
mkirk/options-logic

Conversation

@michaelkirk
Copy link
Member

@michaelkirk michaelkirk commented Feb 5, 2026 •
edited
Loading

  • I agree to follow the project's code of conduct.
  • I added an entry to the project's change log file if knowledge of this change could be valuable to users.
    • Usually called CHANGES.md or CHANGELOG.md
    • Prefix changelog entries for breaking changes with "BREAKING: "

Follow up to #246

LLM was used to help with docs.

@michaelkirk michaelkirk marked this pull request as draft February 5, 2026 18:56
@michaelkirk
Copy link
Member Author

michaelkirk commented Feb 5, 2026

I want to add some more testing for this as the current testing around options is pretty light.

@michaelkirk
Copy link
Member Author

michaelkirk commented Feb 5, 2026

Ok, tests added — passing before and after this refactor.

@michaelkirk michaelkirk marked this pull request as ready for review February 5, 2026 20:07
@urschrei
Copy link
Member

urschrei commented Feb 5, 2026

Yes, very sensible!

@michaelkirk michaelkirk added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit b3b384d Feb 6, 2026
29 checks passed
@michaelkirk michaelkirk deleted the mkirk/options-logic branch February 6, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@urschrei urschrei urschrei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelkirk @urschrei