Add bundled_proj_sqlite feature to support windows-msvc#245
Open
yutannihilation wants to merge 10 commits intogeorust:mainfrom
Open
Add bundled_proj_sqlite feature to support windows-msvc#245yutannihilation wants to merge 10 commits intogeorust:mainfrom
yutannihilation wants to merge 10 commits intogeorust:mainfrom
Conversation
Contributor
Author
|
If I skip the test case, I still see If I run the test case solely, it runs normally (and fails with a normal error). |
Contributor
Author
|
It seems above was a real bug that affects all platforms, not only Windows.I pushed the fix, but I'm happy to create a separate pull request. |
Member
I think pulling it out would be useful. It might be useful to combine it with the ASAN PR? |
This reverts commit 1c9bc45.
Contributor
Author
|
Thanks, I removed the commit from this pull request and pushed to #246 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdorCHANGELOG.mdIn order to make proj-sys work on Windows (more specifically,
windows-msvc. I don't know well aboutwindows-gnu), I found there are at least two options.(I don't describe the details about first option, but here's what it looks like: MIERUNE/point-tiler#64)
For the second option, the proj crate and proj-sys crate already exposes
bundled_proj, but I found it's not enough on Windows' case, where we usually doesn't have SQLite installed. So, this pull request adds a feature flagbundled_proj_sqliteto expose the libsqlite3-sys'sbundledfeature in order to bundle SQLite as well.That's all of this pull request, but I have to explain about some tricky things:
bundled_proj_sqlite, we need to install SQLite on the GHA CI.cargo testrequires some Windows system libraries, otherwise it fails with the following error. So, I added these inbuild.rs.proj::test::test_inverse_projectiontest reliably fails withSTATUS_ACCESS_VIOLATION. I'm yet to figure out what this error is.