Closed
Conversation
nyurik
added a commit
to nyurik/proj
that referenced
this pull request
Feb 23, 2022
This is an alternative, simpler take on georust#110 Adding default constraint allows georust/geo#751
michaelkirk
reviewed
Mar 7, 2022
geo/CHANGES.md
Outdated
| ## Unreleased | ||
|
|
||
| * | ||
| * Add `Default` constraint to all `CoordNum`/`CoordFloat` values. |
Member
There was a problem hiding this comment.
Suggested change
| * Add `Default` constraint to all `CoordNum`/`CoordFloat` values. | |
| * BREAKING: Add `Default` constraint to all `CoordNum`/`CoordFloat` values. |
This would be a breaking change for geo-types right?
I'm not opposed to the new behavior, but it seems like a pretty small QOL improvement.
As such, I'd advocate for holding off on merging this until we have a batch of other more significant reasons to break geo-types.
What do other people think?
Member
Author
There was a problem hiding this comment.
@michaelkirk I'm ok to hold off the default trait. What about other changes - should i split them into a separate PR?
Member
There was a problem hiding this comment.
What about other changes
I'm not sure what remains. Do you mean this?
- T: ::num_traits::Float + ::rstar_0_9::RTreeNum,
+ T: CoordFloat + ::rstar_0_9::RTreeNum,Isn't that also a breaking change?
If there's some non-breaking changes that I missed that you'd like merged, I'd recommend splitting them out.
2 tasks
Also use CoordFloat instead of Float in rstar This PR requires simultaneous modification to the proj repo. See georust#746
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires georust/proj#110 or georust/proj#111 to be released first. See #746 of a potential solution.
Defaulttrait constraint toCoordNumandCoordFloatCoordFloatinstead of::num_traits::Floatfor rstarCHANGES.mdif knowledge of this change could be valuable to users.