remove FQDN reference into metadata_templates

[jeanmi151]

No description provided.

[jeanmi151]

Won't we lose the benefit of setting the domain only in one place and have it configured everywhere? Like for example in https://github.com/georchestra/docker/blob/master/.envs-common or https://github.com/georchestra/helm-charts/blob/139446f0f9b8085b6df48a7365b2ffa3f03297f3/georchestra/values.yaml#L422?

I think being able to modify the domain name only in one place is pretty neat. Some previous migrations have shown that this domain may change for the same client.

(Moving my comment from normal branch to docker branch)

It is part of 3 steps : https://github.com/georchestra/datadir/tree/docker-master?tab=readme-ov-file#3-steps-editing
mandatory before to run geOrchestra (other than with default config)
Before using this datadir, you should at least change the default FQDN (georchestra-127-0-0-1.nip.io) for yours. This can be done very easily with eg:

[pmauduit]

it's unfortunate having the variable already defined elsewhere and not being able to reference it here, but considering the remaining lifetime of the datafeeder + the fact that the datadir won't generally be used by people without modifications (modification which is documented as pointed by @jeanmi151), I guess it is acceptable. I don't have a strong objection here at least.

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	docker-25.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details