Skip to content

Datafeeder init script#474

Closed
jeanmi151 wants to merge 3 commits intodocker-masterfrom
datafeeder_init_script
Closed

Datafeeder init script#474
jeanmi151 wants to merge 3 commits intodocker-masterfrom
datafeeder_init_script

Conversation

@jeanmi151
Copy link
Contributor

init script for datafeeder bootstrap config to avoid copy-datadir and envsubst

copy-datadir and envsubst are only needed by datafeeder, it aims to simplify the docker-compose file (ongoing work)

@jeanmi151 jeanmi151 requested review from f-necas and pmauduit February 9, 2026 12:08
@jeanmi151 jeanmi151 force-pushed the datafeeder_init_script branch from 9cf17a8 to 35fbdca Compare February 9, 2026 12:10
@edevosc2c
Copy link
Member

I believe this script should remain for Camptocamp internal usage only and should not be backported upstream because:

  • It affects Kubernetes deployments using the geOrchestra Helm chart, which relies on the docker-master branch. Running this script there would cause the datadir initialization to happen twice.
  • It copies files to /tmp/georchestra, which is non-standard for both georchestra/docker and georchestra/helm-charts, both of which use /etc/georchestra. This behavior is only required for a Camptocamp Docker Swarm deployment.

Additionally, embedding commands like this is as bad practice as injecting "apt-get install" inside a custom script. Such logic belongs either inside the Docker image or provided by an external program, not in the configuration repository.

@jeanmi151
Copy link
Contributor Author

@edevosc2c this won't be present for kubernetes

it is mainly for docker-compose / swarm compatibility to remove copy-datadir and envsubst (for now I don't see other possibility)

This aim to be public for the future official docker-compose (that I am working on)

I believe injecting command is possible, but it is a none privilege user, so no apt install, but it means the attacker as already full access to the deployment and docker commands (he won't need to inject into env vars ;) ) . I don't think this is a valid attack scenario !

@jeanmi151 jeanmi151 changed the base branch from docker-master to master February 9, 2026 15:29
@jeanmi151 jeanmi151 changed the base branch from master to docker-master February 9, 2026 15:29
@jeanmi151 jeanmi151 closed this Feb 9, 2026
@jeanmi151 jeanmi151 deleted the datafeeder_init_script branch February 10, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants