feat(MapsetKmlFormat): add methods for reading and writing <Document> properties in KML strings #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properties in KML strings
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
oterral
reviewed
Nov 3, 2025
src/ol/utils/MapsetKmlFormat.ts
Outdated
| * @param {String} kmlString A string representing a KML file. | ||
| * @returns {Object} An object containing the document properties (name, description, zoomLimits). | ||
| */ | ||
| public getDocumentProperties( |
Collaborator
There was a problem hiding this comment.
you never use this method, so if it is a utility method for Mapset . Creates someting more generic, so we could use it like this , when we need it (with good type for the parameter):
getDocumentProperty("name")
getDocumentProperty("description")
getDocumentProperty("zoomLimits")
it will be easier to maintain if we add more properties.
oterral
requested changes
Nov 3, 2025
Collaborator
oterral
left a comment
oterral
left a comment
There was a problem hiding this comment.
lgtm , minor refactoring to make more generic. and add tests of course
Contributor
Author
|
@oterral I made the method more generic, please check again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to
Others