Use RTL friendly styling directives for close button#13
Open
nein09 wants to merge 2 commits intogeoapify:masterfrom
Open
Use RTL friendly styling directives for close button#13nein09 wants to merge 2 commits intogeoapify:masterfrom
nein09 wants to merge 2 commits intogeoapify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone. First of all, thanks for making this. I'm using this for a project I'm working on and it's working great for the most part.
I just had to make a patch in my own CSS to override something that didn't work with the RTL version of my site. In Arabic, the close button for the address autocomplete appears on top of the user's input text, like this:
The patch I made moves the close button over to the left, for RTL languages.
This pull request would apply that patch to your repo, if you are interested in using it. It uses logical properties to position the close button, instead of
right, according to these guidelines: https://rtlstyling.com/posts/rtl-styling#logical-properties-cheat-sheet