-
Notifications
You must be signed in to change notification settings - Fork 168
sci-physics/genfit: update EAPI 7 -> 8 #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It installs fine for me but I have some QA warnings: * QA Notice: Compatibility with CMake < 3.5 has been removed from CMake 4,
* sci-physics/genfit will fail to build w/o a fix.
* See also tracker bug #951350; check existing bug or file a new one for
* this package, and take it upstream.
*
* The following CMakeLists.txt files are causing errors:
* CMakeLists.txt:2.8
*
* Compatibility with CMake < 3.10 will be removed in a future release.
* If not fixed in upstream's code repository, we should make sure they are aware.
* See also tracker bug #964405; check existing or file a new bug for this package.
*
* CMake 4 detected; building with -DCMAKE_POLICY_VERSION_MINIMUM=3.5
* This is merely a workaround to avoid CMake Error and *not* a permanent fix;
* there may be new build or runtime bugs as a result.
*
* An upstreamable patch should take any resulting CMake policy changes
* into account. See also:
* https://cmake.org/cmake/help/latest/manual/cmake-policies.7.html
* QA Notice: The following files contain insecure RUNPATHs
* Please file a bug about this at https://bugs.gentoo.org/
* with the maintainer of the package.
* /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/gtestsn RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib:
* /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/minimalFittingExample2n RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
* /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/minimalFittingExamplen RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
* /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/measurementFactoryExamplen RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
* /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/streamerTestn RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
* /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/unitTestsn RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
* /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/fitterTestsn RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
* |
|
One more thing is that it should be revision bumped per
https://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html |
Examples are not well-suited for actual installation, they are only useful for testing and development of the library itself. Signed-off-by: Oliver Freyermuth <o.freyermuth@googlemail.com>
Thanks for catching these! Indeed I initially planned to address these in an update to a more recent snapshot at a later point in time, but as current upstream The The
Thanks, indeed! |
Since 7665cde already changed the EAPI without revbump, I don't think you still need to do it. |
This fixes compatibility with current
cmake.eclass, and also adapts the snapshot version tosci-physics/rootsemantic versioning.