Skip to content

Conversation

@olifre
Copy link
Contributor

@olifre olifre commented Nov 16, 2025

This fixes compatibility with current cmake.eclass, and also adapts the snapshot version to sci-physics/root semantic versioning.

@APN-Pucky APN-Pucky self-assigned this Nov 17, 2025
@APN-Pucky
Copy link
Member

It installs fine for me but I have some QA warnings:

 * QA Notice: Compatibility with CMake < 3.5 has been removed from CMake 4,
 * sci-physics/genfit will fail to build w/o a fix.
 * See also tracker bug #951350; check existing bug or file a new one for
 * this package, and take it upstream.
 * 
 * The following CMakeLists.txt files are causing errors:
 *   CMakeLists.txt:2.8
 * 
 * Compatibility with CMake < 3.10 will be removed in a future release.
 * If not fixed in upstream's code repository, we should make sure they are aware.
 * See also tracker bug #964405; check existing or file a new bug for this package.
 * 
 * CMake 4 detected; building with -DCMAKE_POLICY_VERSION_MINIMUM=3.5
 * This is merely a workaround to avoid CMake Error and *not* a permanent fix;
 * there may be new build or runtime bugs as a result.
 * 
 * An upstreamable patch should take any resulting CMake policy changes
 * into account. See also:
 *   https://cmake.org/cmake/help/latest/manual/cmake-policies.7.html

 * QA Notice: The following files contain insecure RUNPATHs
 *  Please file a bug about this at https://bugs.gentoo.org/
 *  with the maintainer of the package.
 *   /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/gtestsn    RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib:
 *   /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/minimalFittingExample2n    RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
 *   /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/minimalFittingExamplen    RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
 *   /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/measurementFactoryExamplen    RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
 *   /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/streamerTestn    RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
 *   /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/unitTestsn    RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
 *   /var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/image/usr/share/doc/genfit-02.00.00_p20201231/examples/bin/fitterTestsn    RPATH: /usr/lib64/root:/var/tmp/portage/sci-physics/genfit-02.00.00_p20201231/work/GenFit-c3546c073e732abc942a08430b6ca3cb36f5339e_build/lib
 *

@APN-Pucky
Copy link
Member

One more thing is that it should be revision bumped per

changing the EAPI (unless changes to the ebuild are trivial, and you can be sure it won't break stable or reverse dependencies).

https://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html

Examples are not well-suited for actual installation,
they are only useful for testing and development of the library itself.

Signed-off-by: Oliver Freyermuth <o.freyermuth@googlemail.com>
@olifre
Copy link
Contributor Author

olifre commented Nov 18, 2025

It installs fine for me but I have some QA warnings:

Thanks for catching these! Indeed I initially planned to address these in an update to a more recent snapshot at a later point in time, but as current upstream master has different issues, I addressed the QA issues in the fresh force-push.

The RPATH issues affected the examples, which are not really useful to install anyways, as they are only useful for tests and during library development (in those cases the RPATH would fit, but not for packaging), so I dropped the examples flag.

The cmake version problem is already fixed upstream, I backported a simple minimum version bump to the snapshot.

One more thing is that it should be revision bumped per

Thanks, indeed!
Given that all cmake.eclass-using packages in the overlay have been EAPI-bumped recently (including this one), should I still do the revbump?

@APN-Pucky
Copy link
Member

Given that all cmake.eclass-using packages in the overlay have been EAPI-bumped recently (including this one), should I still do the revbump?

Since 7665cde already changed the EAPI without revbump, I don't think you still need to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants