Skip to content

Conversation

@robbat2
Copy link
Contributor

@robbat2 robbat2 commented Feb 6, 2023

Signed-off-by: Robin H. Johnson robbat2@gentoo.org

@robbat2
Copy link
Contributor Author

robbat2 commented Feb 6, 2023

It's not perfect yet, I couldn't figure out how how to mock socket.getaddrinfo for testing

@mgorny
Copy link
Member

mgorny commented Feb 15, 2023

My first concern is that this bypasses proxy.

@robbat2
Copy link
Contributor Author

robbat2 commented Feb 16, 2023

Hmm, the spec does say to do the advanced/direct switch depending if the hostname exists.
How do we make that determination behind a proxy? Do we trust that the HTTPS request via the proxy returns a meaningful 404 vs actual data?

robbat2 and others added 4 commits April 21, 2023 14:01
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants