add a dockerfile to build the sciClone package#57
Open
shenkers wants to merge 1 commit intogenome:masterfrom
Open
add a dockerfile to build the sciClone package#57shenkers wants to merge 1 commit intogenome:masterfrom
shenkers wants to merge 1 commit intogenome:masterfrom
Conversation
Author
|
update: it looks like the image doesn't work as is, I think because it runs in R v4, and something about how data-frame slicing by column index changed ( df[,1] used to return a vector, but now returns a 1-column data.frame? ). It looks like there are a lot of places that this sort of slicing is used, so it probably makes sense to use an R environment that mimics the original setup. I was browsing the issues and saw your reference to seqfu/sciclone docker image, it looks like theirs uses R 3.6.3 and BioConductor 3.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @chrisamiller ,
I'm doing a volunteer project with a PI and wanted to run sciClone on the dataset. I saw that you had install instructions, but thought it might be nice for future visitors if there was a docker image. I guess ideally someone like biocontainers could host it so users don't have to build it, but thought even having the Dockerfile would make it easier for people to use.
Let me know if you have any feedback on the change.
Best,
Sol