Port XSL to Javascript #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a straightforward port of the previous pretty-feed-v3.xsl to Javascript. This removes the need for XSL, which is due to be removed from most major browsers in the next year or so, while maintaining the functionality of showing a styled feed to users who might not be familiar with what feeds are and who would be understandably put out by a website spaffing a load of raw XML at them.
Rather than linking feed owners to the XSL version of Pretty Feed, which is due to stop working at some point soon as browsers drop XSL support, link to the Javascript version instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome has announced that it's gradually removing XSL support from the browser over the next year; Firefox and Webkit are doing likewise.
With that in mind, and getting ahead of the deprecation, this pull request ports the existing XSL implementation of Pretty Feed to Javascript, with a technique outlined here by Jake Archibald.
It's functionally and stylistically identical to the XSL, just in JS.