Fix a bug in download_and_rename method#401
Merged
gregorjerse merged 3 commits intogenialis:masterfrom Jan 29, 2026
Merged
Conversation
gregorjerse
requested changes
Jan 13, 2026
gregorjerse
force-pushed
the
fix/download_and_rename
branch
from
3238c4b to
7eb3ae2
Compare
marcellevstek
force-pushed
the
fix/download_and_rename
branch
from
7eb3ae2 to
0268f9d
Compare
gregorjerse
force-pushed
the
fix/download_and_rename
branch
from
0268f9d to
7eb3ae2
Compare
marcellevstek
force-pushed
the
fix/download_and_rename
branch
from
7eb3ae2 to
91bfb4b
Compare
marcellevstek
commented
Jan 13, 2026
|
|
||
| return file_names | ||
| dir_names = self._files_dirs("dir", file_name, field_name) | ||
| if dir_names and return_dir_names: |
Contributor
Author
There was a problem hiding this comment.
@gregorjerse this works as intended, but if a user does not specify a field or file name, only the directory names get returned. This may seem problematic, if the user expects the file names not contained in the directories to be returned as well.
gregorjerse
approved these changes
Jan 28, 2026
marcellevstek
force-pushed
the
fix/download_and_rename
branch
5 times, most recently
from
8b41c1f to
6dc69e4
Compare
marcellevstek
force-pushed
the
fix/download_and_rename
branch
from
6dc69e4 to
448c5a1
Compare
marcellevstek
force-pushed
the
fix/download_and_rename
branch
from
448c5a1 to
1e18908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem affected cases when you wanted to download the same field of related data objects and wanted to avoid them being overwritten. The bug caused the code to fail when trying to rename the file names contained in the directory.