Conversation
- context.tf, iam.tf, example/context.tf, example/ecr.tf: replace git::git@github.com: SSH sources with git::https://github.com/ HTTPS equivalents — SSH fails in CI and any environment without SSH keys configured for GitHub - README.md: replace local ./AppRunner source paths in usage examples with real GitHub HTTPS ref (1.0.5-AppRunner) - SPECS.md: regenerated via terraform-docs markdown table - project.json: bump 1.0.4 → 1.0.5 (patch — bug fix + docs)
jonryser
force-pushed
the
fix/apprunner-context-null-validation
branch
from
573ecdf to
8c16dfb
Compare
jonryser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follows up on #28 (null validation fix). Completes the full module checklist for the AppRunner module.
Edited ALL modules to reference other modules via https instead of ssh.
Changes
context.tf,iam.tf,example/context.tf,example/ecr.tf: Replacegit::git@github.com:SSH sources withgit::https://github.com/HTTPS equivalents — SSH fails in CI and any environment without SSH keys configured for GitHubREADME.md: Replace local./AppRunnersource paths in usage examples with real GitHub HTTPS ref (1.0.5-AppRunner)SPECS.md: Regenerated viaterraform-docs markdown table --output-file SPECS.md --output-mode inject ./project.json: Bump1.0.4→1.0.5(patch — bug fix + docs)Checklist
project.jsonversion bumpedSPECS.mdregenerated via terraform-docsREADME.mdupdated with correct source refsterraform fmt -recursivecleanterraform validatepasses