test: strengthen tool tests and add linear_view coverage#5
Merged
Conversation
genui-scotty
bot
force-pushed
the
feat/test-quality
branch
from
fe6c1af to
f205296
Compare
- Add test/tools/linear-view-tool.test.ts (was 0%, now 98% statements) Tests verify actual GraphQL variables, null fallback, invalid JSON - Rewrite linear-issue-tool tests: verify mutation input composition and resolver call arguments, not just mocked return values - list: verify query variables (state, team uppercased, assignee, project, default limit 50) - create: verify all 6 resolver calls with correct args and that the composed mutation input has correct keys/values - delete: verify resolved UUID sent to mutation - update: appendDescription both branches, dueDate null-clearing, team-scoped label resolution - Remove trivial 'has correct name' tests from all tool files 378 tests passing, src/tools at 97% statements / 90% branch coverage
genui-scotty
bot
force-pushed
the
feat/test-quality
branch
from
f205296 to
9efa493
Compare
jonryser
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Addressed the placeholder
describe.todo()note — the test suite now has real, meaningful coverage.Changes
New:
test/tools/linear-view-tool.test.tslinear_viewwas completely untested (0%). Now at 98% statement coverage.Strengthened
linear-issue-tool.test.ts:create: verifies all 6 resolver calls with correct args, and that the composed mutationinputobject has the right keys/valueslist: verifies actual query variables (state, team uppercased, assignee, project, default limit 50)delete: verifies the resolved UUID is sent to the mutationupdate: appendDescription both branches, dueDate null-clearing, team-scoped label resolutionCleaned up all tool tests:
query.includes("keyword")Coverage (src/tools)
374 tests passing.