Add support for accessing the raw action and raw action creator#5
Open
qwerty0981 wants to merge 1 commit intogeneralui:masterfrom
Open
Add support for accessing the raw action and raw action creator#5qwerty0981 wants to merge 1 commit intogeneralui:masterfrom
qwerty0981 wants to merge 1 commit intogeneralui:masterfrom
Conversation
Member
|
Thanks for this submission! I wish Github notified me of it ;). I'm just noticing it now. I'll dive in deeper in a bit and see if it fits. |
Member
|
Quick glance at the changes... looks pretty good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add API for accessing raw action and raw action creator
This PR adds support for accessing the generated action type and having a minimal API for accessing the internal raw action creator. Having access to these pieces of information would cover the only use-case that I have found where the pre-loaded action creators created by
hooks-for-reduxwere not sufficient, using redux middleware likeredux-sagaorredux-rx.Both of the middleware mentioned above need to have access to the raw action type to be used effectively and
redux-rxspecifically needs access to the basic action creator for use inbindActionCreators().Example
Example usage in
redux-saga(this integration was impossible before)