Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The "job status" page provides feedback by refreshing every 5 sec.
When the queue is long, the server can experience loss of service quality just from status page checks alone. (see related connection pool issue)
The new proposed value of 20 sec will reduce server load by ~75% for running job status checks, while still giving users frequent visible feedback during "fast" parts of the process like QC.
Combined with other recent changes (DB indices, increased connection pool etc), this should be sufficient to prevent DoS when the site is used under normal conditions.
This will be included in our next fork release, and we're contributing it back for others.
Related: