Skip to content

WalletConnect permissions ui fix #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DRadmir wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WalletConnect permissions ui fix #1806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afab892
Add fontWeight support to AssetImageView and bold WalletConnect permi…
DRadmir Mar 19, 2026
5e27b89
Remove "Move funds" permission from WalletConnect proposal
DRadmir Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ...ures/WalletConnector/Sources/WalletConnector/ViewModels/ConnectionProposalViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,11 @@ public struct ConnectionProposalViewModel {
[
ListItemModel(
title: Localized.WalletConnect.Permissions.viewBalance,
imageStyle: .accessory(assetImage: .image(Images.System.checkmark))
imageStyle: .accessory(assetImage: .image(Images.System.checkmark), fontWeight: .semibold)
),
ListItemModel(
title: Localized.WalletConnect.Permissions.approvalRequests,
imageStyle: .accessory(assetImage: .image(Images.System.checkmark))
),
ListItemModel(
title: Localized.WalletConnect.Permissions.moveFunds,
titleStyle: TextStyle(font: .body, color: Colors.secondaryText),
imageStyle: .accessory(assetImage: .image(Images.System.xmark), foregroundColor: Colors.gray)
imageStyle: .accessory(assetImage: .image(Images.System.checkmark), fontWeight: .semibold)
),
]
}
Expand Down
8 changes: 7 additions & 1 deletion Packages/Components/Sources/AssetImageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ public struct AssetImageView: View {
)
.frame(width: size, height: size)
.cornerRadius(cornerRadius)
.ifLet(style?.fontWeight) { view, weight in
view.fontWeight(weight)
}
.ifLet(style?.foregroundColor) { view, color in
view.foregroundStyle(color)
}
Expand Down Expand Up @@ -110,13 +113,16 @@ extension AssetImageView {
public struct Style: Sendable, Equatable {
public let foregroundColor: Color?
public let cornerRadius: CGFloat?
public let fontWeight: Font.Weight?

public init(
foregroundColor: Color? = nil,
cornerRadius: CGFloat? = nil
cornerRadius: CGFloat? = nil,
fontWeight: Font.Weight? = nil
) {
self.foregroundColor = foregroundColor
self.cornerRadius = cornerRadius
self.fontWeight = fontWeight
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion Packages/Components/Sources/Lists/ListItemView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public struct ListItemView: View {
AssetImageView(
assetImage: imageStyle.assetImage,
size: imageStyle.imageSize,
style: .init(foregroundColor: imageStyle.foregroundColor, cornerRadius: imageStyle.cornerRadius)
style: .init(foregroundColor: imageStyle.foregroundColor, cornerRadius: imageStyle.cornerRadius, fontWeight: imageStyle.fontWeight)
)
}
HStack {
Expand Down
6 changes: 5 additions & 1 deletion Packages/Components/Sources/Types/ListItemImageStyle.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ public struct ListItemImageStyle: Sendable {
public let imageSize: CGFloat
public let alignment: VerticalAlignment
public let foregroundColor: Color?
public let fontWeight: Font.Weight?
private let cornerRadiusType: CornerRadiusType

public var cornerRadius: CGFloat {
Expand All @@ -24,6 +25,7 @@ public struct ListItemImageStyle: Sendable {
imageSize: CGFloat,
alignment: VerticalAlignment = .center,
foregroundColor: Color? = nil,
fontWeight: Font.Weight? = nil,
cornerRadiusType: CornerRadiusType
) {
guard let assetImage else { return nil }
Expand All @@ -32,6 +34,7 @@ public struct ListItemImageStyle: Sendable {
self.cornerRadiusType = cornerRadiusType
self.alignment = alignment
self.foregroundColor = foregroundColor
self.fontWeight = fontWeight
}

public enum CornerRadiusType: Sendable {
Expand All @@ -58,11 +61,12 @@ public extension ListItemImageStyle {
)
}

static func accessory(assetImage: AssetImage?, foregroundColor: Color? = nil) -> Self? {
static func accessory(assetImage: AssetImage?, foregroundColor: Color? = nil, fontWeight: Font.Weight? = nil) -> Self? {
ListItemImageStyle(
assetImage: assetImage,
imageSize: .space12,
foregroundColor: foregroundColor,
fontWeight: fontWeight,
cornerRadiusType: .none
)
}
Expand Down
Loading