Navigate to perpetual screen for perpetual asset push notifications#1804
Navigate to perpetual screen for perpetual asset push notifications#1804gemcoder21 merged 3 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the application's navigation system by introducing specific handling for perpetual assets. It ensures that when a user interacts with a perpetual asset, whether directly or via a transaction, they are directed to a dedicated 'perpetual' screen, providing a tailored experience for this asset type. This change is crucial for supporting future features related to perpetual assets and improving clarity in the user interface. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the navigation logic to correctly handle perpetual assets, directing users to the perpetuals screen when a push notification for such an asset is received. The changes are logical and address the feature requirement. I've added one suggestion to refactor a small piece of duplicated code for better maintainability.
| if asset.type == .perpetual { | ||
| navigationState.wallet.setPath([Scenes.Perpetual(asset), Scenes.Transaction(transaction: transactionExtended)]) | ||
| } else { | ||
| navigationState.wallet.setPath([Scenes.Asset(asset: asset), Scenes.Transaction(transaction: transactionExtended)]) | ||
| } |
There was a problem hiding this comment.
To improve maintainability and reduce code duplication, you can determine the assetScene first and then call setPath once. This avoids repeating the setPath call and the creation of the Scenes.Transaction object.
| if asset.type == .perpetual { | |
| navigationState.wallet.setPath([Scenes.Perpetual(asset), Scenes.Transaction(transaction: transactionExtended)]) | |
| } else { | |
| navigationState.wallet.setPath([Scenes.Asset(asset: asset), Scenes.Transaction(transaction: transactionExtended)]) | |
| } | |
| let assetScene: any Hashable = if asset.type == .perpetual { | |
| Scenes.Perpetual(asset) | |
| } else { | |
| Scenes.Asset(asset: asset) | |
| } | |
| navigationState.wallet.setPath([assetScene, Scenes.Transaction(transaction: transactionExtended)]) |
| } | ||
|
|
||
| navigationState.wallet.setPath([Scenes.Asset(asset: asset), Scenes.Transaction(transaction: transactionExtended)]) | ||
| if asset.type == .perpetual { |
No description provided.