Skip to content

Navigate to perpetual screen for perpetual asset push notifications#1804

Merged
gemcoder21 merged 3 commits intomainfrom
perpetual-push-navigation
Mar 18, 2026
Merged

Navigate to perpetual screen for perpetual asset push notifications#1804
gemcoder21 merged 3 commits intomainfrom
perpetual-push-navigation

Conversation

@DRadmir
Copy link
Contributor

@DRadmir DRadmir commented Mar 18, 2026

No description provided.

@DRadmir DRadmir self-assigned this Mar 18, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's navigation system by introducing specific handling for perpetual assets. It ensures that when a user interacts with a perpetual asset, whether directly or via a transaction, they are directed to a dedicated 'perpetual' screen, providing a tailored experience for this asset type. This change is crucial for supporting future features related to perpetual assets and improving clarity in the user interface.

Highlights

  • Conditional Navigation: Implemented conditional navigation logic within NavigationHandler to differentiate between standard assets and perpetual assets.
  • Perpetual Asset Scene: Introduced navigation to a dedicated Scenes.Perpetual screen when handling perpetual assets, ensuring a specialized user experience.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the navigation logic to correctly handle perpetual assets, directing users to the perpetuals screen when a push notification for such an asset is received. The changes are logical and address the feature requirement. I've added one suggestion to refactor a small piece of duplicated code for better maintainability.

Comment on lines +158 to +162
if asset.type == .perpetual {
navigationState.wallet.setPath([Scenes.Perpetual(asset), Scenes.Transaction(transaction: transactionExtended)])
} else {
navigationState.wallet.setPath([Scenes.Asset(asset: asset), Scenes.Transaction(transaction: transactionExtended)])
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce code duplication, you can determine the assetScene first and then call setPath once. This avoids repeating the setPath call and the creation of the Scenes.Transaction object.

Suggested change
if asset.type == .perpetual {
navigationState.wallet.setPath([Scenes.Perpetual(asset), Scenes.Transaction(transaction: transactionExtended)])
} else {
navigationState.wallet.setPath([Scenes.Asset(asset: asset), Scenes.Transaction(transaction: transactionExtended)])
}
let assetScene: any Hashable = if asset.type == .perpetual {
Scenes.Perpetual(asset)
} else {
Scenes.Asset(asset: asset)
}
navigationState.wallet.setPath([assetScene, Scenes.Transaction(transaction: transactionExtended)])

}

navigationState.wallet.setPath([Scenes.Asset(asset: asset), Scenes.Transaction(transaction: transactionExtended)])
if asset.type == .perpetual {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use switch

@gemcoder21 gemcoder21 merged commit 97591dc into main Mar 18, 2026
1 check passed
@gemcoder21 gemcoder21 deleted the perpetual-push-navigation branch March 18, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants