Skip to content

WalletConnect: Add app preview & permissions UI#1803

Merged
DRadmir merged 2 commits intomainfrom
1798-add-permissions-for-walletconnect-session-approval
Mar 18, 2026
Merged

WalletConnect: Add app preview & permissions UI#1803
DRadmir merged 2 commits intomainfrom
1798-add-permissions-for-walletconnect-session-approval

Conversation

@DRadmir
Copy link
Contributor

@DRadmir DRadmir commented Mar 18, 2026

Replace header AsyncImageView with AssetPreviewView and add AppPreviewModel to represent app preview data. Expose appPreview and permissions from SignMessage and ConnectionProposal view models and render a permissions section in ConnectionProposalScene. Add PermissionItemView, adjust ListItemImageStyle to support foregroundColor and update ListItemView to pass it through. Include spacing/content margin tweaks and add new localization keys for portfolio and permissions across languages.

Simulator Screenshot - iPhone 17 Pro - 2026-03-18 at 18 07 34 Simulator Screenshot - iPhone 17 Pro - 2026-03-18 at 18 08 20 Simulator Screenshot - iPhone 17 Pro - 2026-03-18 at 21 37 50

Close: #1798

Replace header AsyncImageView with AssetPreviewView and add AppPreviewModel to represent app preview data. Expose appPreview and permissions from SignMessage and ConnectionProposal view models and render a permissions section in ConnectionProposalScene. Add PermissionItemView, adjust ListItemImageStyle to support foregroundColor and update ListItemView to pass it through. Include spacing/content margin tweaks and add new localization keys for portfolio and permissions across languages.
@DRadmir DRadmir self-assigned this Mar 18, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user interface for WalletConnect interactions by introducing dedicated app preview and permissions display sections. It refactors how app information is presented, moving towards a more standardized and visually appealing approach, and ensures that users are clearly informed about the permissions requested by connected dApps. The changes also include foundational updates to UI components and comprehensive localization support.

Highlights

  • Enhanced UI for WalletConnect Scenes: The ConnectionProposalScene and SignMessageScene have been updated to display a dedicated app preview section, replacing the previous AsyncImageView with the new AssetPreviewView.
  • Permissions Display in Connection Proposal: A new section has been added to the ConnectionProposalScene to clearly list the permissions requested by the dApp, improving transparency for users.
  • New AppPreviewModel and AssetPreviewable Protocol: Introduced AppPreviewModel to standardize the data structure for app previews and the AssetPreviewable protocol to allow various view models to conform to a common interface for displaying asset previews.
  • Improved ListItemImageStyle: The ListItemImageStyle now supports a foregroundColor property, enabling more flexible styling of list item images, particularly for accessory icons.
  • Localization Updates: New localization keys for 'Portfolio' and 'Permissions' have been added across multiple languages to support the new UI elements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully integrates new UI components for app previews and permissions in WalletConnect scenes. The introduction of AssetPreviewable protocol and AppPreviewModel enhances modularity and reusability. The localization updates are comprehensive, ensuring the new UI elements are properly supported across all languages. The changes are well-implemented and align with the stated objectives.

@gemcoder21
Copy link
Contributor

Screenshot 2026-03-18 at 6 15 26 PM

Split into 2 lines

/// Move funds without permission
public static let moveFunds = Localized.tr("Localizable", "wallet_connect.permissions.move_funds", fallback: "Move funds without permission")
/// Requested permissions
public static let title = Localized.tr("Localizable", "wallet_connect.permissions.title", fallback: "Requested permissions")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static let title = Localized.tr("Localizable", "wallet_connect.permissions.title", fallback: "Requested permissions")
public static let title = Localized.tr("Localizable", "wallet_connect.permissions.title", fallback: "Permissions")

@DRadmir DRadmir merged commit 03d42ba into main Mar 18, 2026
1 check passed
@DRadmir DRadmir deleted the 1798-add-permissions-for-walletconnect-session-approval branch March 18, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add permissions for WalletConnect session approval

3 participants