WalletConnect: Add app preview & permissions UI#1803
Conversation
Replace header AsyncImageView with AssetPreviewView and add AppPreviewModel to represent app preview data. Expose appPreview and permissions from SignMessage and ConnectionProposal view models and render a permissions section in ConnectionProposalScene. Add PermissionItemView, adjust ListItemImageStyle to support foregroundColor and update ListItemView to pass it through. Include spacing/content margin tweaks and add new localization keys for portfolio and permissions across languages.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user interface for WalletConnect interactions by introducing dedicated app preview and permissions display sections. It refactors how app information is presented, moving towards a more standardized and visually appealing approach, and ensures that users are clearly informed about the permissions requested by connected dApps. The changes also include foundational updates to UI components and comprehensive localization support. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully integrates new UI components for app previews and permissions in WalletConnect scenes. The introduction of AssetPreviewable protocol and AppPreviewModel enhances modularity and reusability. The localization updates are comprehensive, ensuring the new UI elements are properly supported across all languages. The changes are well-implemented and align with the stated objectives.
| /// Move funds without permission | ||
| public static let moveFunds = Localized.tr("Localizable", "wallet_connect.permissions.move_funds", fallback: "Move funds without permission") | ||
| /// Requested permissions | ||
| public static let title = Localized.tr("Localizable", "wallet_connect.permissions.title", fallback: "Requested permissions") |
There was a problem hiding this comment.
| public static let title = Localized.tr("Localizable", "wallet_connect.permissions.title", fallback: "Requested permissions") | |
| public static let title = Localized.tr("Localizable", "wallet_connect.permissions.title", fallback: "Permissions") |
Replace header AsyncImageView with AssetPreviewView and add AppPreviewModel to represent app preview data. Expose appPreview and permissions from SignMessage and ConnectionProposal view models and render a permissions section in ConnectionProposalScene. Add PermissionItemView, adjust ListItemImageStyle to support foregroundColor and update ListItemView to pass it through. Include spacing/content margin tweaks and add new localization keys for portfolio and permissions across languages.
Close: #1798