Earn yielder integration by gemdev111 · Pull Request #1787 · gemwalletcom/gem-ios

gemdev111 · 2026-03-12T14:26:41Z

No description provided.

Introduce EarnBalanceUpdatable protocol and have BalanceService conform to it so earn balances can be updated via a shared interface. EarnService now accepts an EarnBalanceUpdatable dependency and triggers an earn balance refresh after updating positions. ServicesFactory is updated to inject the balance service into EarnService, and Package.swift adds the BalanceService dependency for the EarnService target. BalanceStore gains hasEarnBalance(...) to gate earn updates, the TransactionStateService testkit adds an EarnBalanceUpdaterMock and updated mock constructor, and a small UI label change for earn deposit was applied. Also bumps core submodule commit.

Show provider/earn-specific labels and capitalize names across stake/transaction/transfer views. Changes include: capitalizing validator name for .earn; adding earnProviderItemModel and routing .earnDeposit/.earnWithdraw to it in TransactionParticipantViewModel (and using Localized.Common.provider as the label); and updating ConfirmRecipientViewModel to use the provider title for .earn and make recipient input visible for earn flows. Files updated: ValidatorViewModel.swift, TransactionParticipantViewModel.swift, ConfirmRecipientViewModel.swift.

gemini-code-assist · 2026-03-12T14:28:10Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the integration of 'Earn yielder' functionality by introducing a new protocol for managing earn balance updates, refactoring the EarnService to utilize this protocol, and updating the BalanceService accordingly. It also includes several UI adjustments to accurately display earn-related transaction details and validator names, ensuring a consistent and robust user experience for earn features.

Highlights

Earn Balance Update Protocol: Introduced a new EarnBalanceUpdatable protocol to standardize and abstract the process of updating earn balances, promoting a more modular architecture.
Earn Service Refactoring: Refactored the EarnService to depend on the new EarnBalanceUpdatable protocol, allowing for flexible and testable earn balance updates.
Balance Service Integration: Updated BalanceService to conform to the EarnBalanceUpdatable protocol and adjusted its logic to conditionally update earn balances based on existing records.
UI Text and Participant Handling: Enhanced transaction and recipient view models to correctly display 'Earn' related transaction participants and titles, including capitalizing validator names for earn cases and showing 'Provider' for earn deposits/withdrawals.
Balance Store Utility: Added a hasEarnBalance utility function to BalanceStore to efficiently check for the existence of earn balances for a given wallet and chain.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

Features/Stake/Sources/ViewModels/ValidatorViewModel.swift
- Capitalized the validator name for .earn cases.
Features/Transactions/Sources/ViewModels/TransactionParticipantViewModel.swift
- Updated itemModel to use earnProviderItemModel for earnDeposit and earnWithdraw transaction types.
- Added a private computed property earnProviderItemModel.
- Modified title to return Localized.Common.provider for earnDeposit and earnWithdraw types.
Features/Transfer/Sources/ViewModels/ConfirmRecipientViewModel.swift
- Changed the recipient title for .earn type to Localized.Common.provider.
- Adjusted the isEditable logic for .earn type.
Gem/Services/ServicesFactory.swift
- Modified EarnService initialization to pass balanceService as earnBalanceUpdater.
Packages/FeatureServices/BalanceService/BalanceService.swift
- Modified updateAllBalances to conditionally update earn balances based on hasEarnBalance.
- Removed the private updateEarnBalance function.
- Extended BalanceService to conform to EarnBalanceUpdatable and implemented its updateEarnBalance method.
Packages/FeatureServices/BalanceService/Protocols/EarnBalanceUpdatable.swift
- Added a new public protocol EarnBalanceUpdatable.
Packages/FeatureServices/EarnService/EarnService.swift
- Imported BalanceService.
- Added earnBalanceUpdater property and updated the initializer.
- Called earnBalanceUpdater.updateEarnBalance after updating positions.
Packages/FeatureServices/Package.swift
- Added BalanceService as a dependency for EarnService.
Packages/FeatureServices/TransactionStateService/TestKit/TransactionStateService+TestKit.swift
- Added earnBalanceUpdater parameter to EarnService.mock.
- Introduced EarnBalanceUpdaterMock for testing.
Packages/PrimitivesComponents/Sources/ViewModels/TransactionViewModel.swift
- Changed the title for earnDeposit to Localized.Common.earn.
Packages/Store/Sources/Stores/BalanceStore.swift
- Added a hasEarnBalance function to check for existing earn balances.
core
- Updated the submodule commit hash.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request integrates the 'Earn' yielder functionality across various features. The changes include UI updates for displaying earn-related information, service layer modifications to handle earn logic, and database extensions to support earn balances. A notable improvement is the refactoring in EarnService and BalanceService to use the EarnBalanceUpdatable protocol, which decouples the services and improves modularity. My review includes one suggestion for improving code style and readability.

gemini-code-assist · 2026-03-12T14:30:33Z

Packages/FeatureServices/BalanceService/BalanceService.swift

+                }
+
+                // earn balance
+                if (try? balanceStore.hasEarnBalance(walletId: walletId, chain: chain)) == true {


This condition is functionally correct, but it can be written more concisely and idiomatically in Swift. Using the nil-coalescing operator ?? can make the intent clearer by treating a nil result from the throwing function as false.

Suggested change

if (try? balanceStore.hasEarnBalance(walletId: walletId, chain: chain)) == true {

if (try? balanceStore.hasEarnBalance(walletId: walletId, chain: chain)) ?? false {

gemcoder21 · 2026-03-12T17:12:07Z

Packages/FeatureServices/EarnService/EarnService.swift

 public struct EarnService: Sendable {
    private let store: StakeStore
    private let gatewayService: GatewayService
+    private let earnBalanceUpdater: any EarnBalanceUpdatable


Suggested change

private let earnBalanceUpdater: any EarnBalanceUpdatable

private let balanceUpdater: any EarnBalanceUpdatable

gemcoder21 · 2026-03-12T17:12:13Z

Packages/FeatureServices/EarnService/EarnService.swift

-
        try updatePositions(walletId: walletId, assetId: assetId, positions: positions)
+
+        await earnBalanceUpdater.updateEarnBalance(walletId: walletId, chain: assetId.chain, address: address)


Suggested change

await earnBalanceUpdater.updateEarnBalance(walletId: walletId, chain: assetId.chain, address: address)

await balanceUpdater.updateEarnBalance(walletId: walletId, chain: assetId.chain, address: address)

gemcoder21 · 2026-03-12T17:12:27Z

Packages/FeatureServices/TransactionStateService/TestKit/TransactionStateService+TestKit.swift

    ) -> EarnService {
        let provider = NativeProvider(url: Constants.apiURL, requestInterceptor: EmptyRequestInterceptor())
-        return EarnService(store: store, gatewayService: GatewayService(provider: provider))
+        return EarnService(store: store, gatewayService: GatewayService(provider: provider), earnBalanceUpdater: earnBalanceUpdater)


Suggested change

return EarnService(store: store, gatewayService: GatewayService(provider: provider), earnBalanceUpdater: earnBalanceUpdater)

return EarnService(store: store, gatewayService: GatewayService(provider: provider), balanceUpdater: balanceUpdater)

gemcoder21 · 2026-03-12T17:14:17Z

Packages/Store/Sources/Stores/BalanceStore.swift

+        try db.read { db in
+            try BalanceRecord
+                .filter(BalanceRecord.Columns.walletId == walletId.id)
+                .filter(BalanceRecord.Columns.assetId.like("\(chain.rawValue)%"))


Suggested change

.filter(BalanceRecord.Columns.assetId.like("\(chain.rawValue)%"))

.filter(BalanceRecord.Columns.chain = chain.rawValue )

gemcoder21 · 2026-03-12T17:15:39Z

Features/Transactions/Sources/ViewModels/TransactionParticipantViewModel.swift

+    private var earnProviderItemModel: TransactionItemModel {
+        let address = transactionViewModel.participant
+        let addressName = transactionViewModel.getAddressName(address: address)
+        let name = (addressName?.name ?? address).capitalized


Suggested change

let name = (addressName?.name ?? address).capitalized

gemcoder21 · 2026-03-12T17:15:48Z

Features/Stake/Sources/ViewModels/ValidatorViewModel.swift

            return validator.name
        case .earn:
-            return validator.name
+            return validator.name.capitalized


Suggested change

return validator.name.capitalized

return validator.name

Update getEarnBalance to accept [AssetId] tokenIds, consistent with tokenBalance pattern. BalanceService passes wallet's token IDs so only chains with matching earn assets trigger RPC calls.

Use contract address as recipient so provider is shown with explorer link, matching staking validator display pattern

gemdev111 added 4 commits March 10, 2026 17:25

Update core

ed410d4

Merge branch 'main' into earn-yielder-integration

26af974

gemini-code-assist bot reviewed Mar 12, 2026

View reviewed changes

Fix tests

a3569b4

gemcoder21 reviewed Mar 12, 2026

View reviewed changes

gemdev111 added 10 commits March 12, 2026 21:34

Update core

8a722e2

Merge branch 'main' into earn-yielder-integration

1264cfb

Delete TransactionStateService+TestKit.swift

d6de511

Merge branch 'main' into earn-yielder-integration

0aef566

Update core

d5879a0

undo TransactionStateService

2ae445c

updates core

954d776

Removed uneeded checks

303e6a7

Pass token IDs to earn balance fetch for targeted RPC calls

0ffc887

Update getEarnBalance to accept [AssetId] tokenIds, consistent with tokenBalance pattern. BalanceService passes wallet's token IDs so only chains with matching earn assets trigger RPC calls.

Update core

788cbb2

gemcoder21 approved these changes Mar 17, 2026

View reviewed changes

gemdev111 added 7 commits March 18, 2026 02:22

Update core , added update for earn apr

a5e8579

Merge branch 'main' into earn-yielder-integration

e4c0392

Persist earnApr from API to asset store

b5017fb

Show earn provider in confirm and transaction history

4a1a9b1

Use contract address as recipient so provider is shown with explorer link, matching staking validator display pattern

Update TransactionViewModel.swift

a3c8b6d

Update core

4603ecd

Merge branch 'main' into earn-yielder-integration

b1e656f

gemdev111 marked this pull request as ready for review March 18, 2026 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Earn yielder integration#1787

Earn yielder integration#1787
gemdev111 wants to merge 22 commits intomainfrom
earn-yielder-integration

gemdev111 commented Mar 12, 2026

Uh oh!

gemini-code-assist bot commented Mar 12, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 12, 2026

Uh oh!

gemcoder21 Mar 12, 2026

Uh oh!

gemcoder21 Mar 12, 2026

Uh oh!

gemcoder21 Mar 12, 2026

Uh oh!

gemcoder21 Mar 12, 2026

Uh oh!

gemcoder21 Mar 12, 2026

Uh oh!

gemcoder21 Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if (try? balanceStore.hasEarnBalance(walletId: walletId, chain: chain)) == true {
	if (try? balanceStore.hasEarnBalance(walletId: walletId, chain: chain)) ?? false {

	private let earnBalanceUpdater: any EarnBalanceUpdatable
	private let balanceUpdater: any EarnBalanceUpdatable


		try updatePositions(walletId: walletId, assetId: assetId, positions: positions)

		await earnBalanceUpdater.updateEarnBalance(walletId: walletId, chain: assetId.chain, address: address)

	await earnBalanceUpdater.updateEarnBalance(walletId: walletId, chain: assetId.chain, address: address)
	await balanceUpdater.updateEarnBalance(walletId: walletId, chain: assetId.chain, address: address)

	return EarnService(store: store, gatewayService: GatewayService(provider: provider), earnBalanceUpdater: earnBalanceUpdater)
	return EarnService(store: store, gatewayService: GatewayService(provider: provider), balanceUpdater: balanceUpdater)

	.filter(BalanceRecord.Columns.assetId.like("\(chain.rawValue)%"))
	.filter(BalanceRecord.Columns.chain = chain.rawValue )

Conversation

gemdev111 commented Mar 12, 2026

Uh oh!

gemini-code-assist bot commented Mar 12, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemcoder21 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemcoder21 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemcoder21 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemcoder21 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemcoder21 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemcoder21 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants