Skip to content

Refactor swap referral configs#1018

Merged
0xh3rman merged 4 commits intomainfrom
refactor-swap-referral
Mar 19, 2026
Merged

Refactor swap referral configs#1018
0xh3rman merged 4 commits intomainfrom
refactor-swap-referral

Conversation

@0xh3rman
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the fee management system within the swapper crate by introducing a new, centralized fees module. This change consolidates referral fee configurations, slippage calculations, and reserved fee definitions into a single, well-organized location. The primary goal is to enhance code maintainability and clarity by separating fee-related logic from general configuration, making it easier to manage and extend fee structures in the future.

Highlights

  • Refactored Fee Configuration: The ReferralFee and ReferralFees structs, along with their associated logic and default values, were moved from crates/swapper/src/config.rs to a new dedicated module crates/swapper/src/fees/referral.rs to centralize fee-related definitions.
  • Introduced New fees Module: A new top-level crates/swapper/src/fees module was created to consolidate all fee-related logic, including referral fees, reserved fees, and slippage calculations, improving overall code organization.
  • Relocated Slippage and Reserved Fee Logic: The slippage module was moved into crates/swapper/src/fees/slippage.rs, and the existing fees.rs (containing reserved fees) was renamed to crates/swapper/src/fees/reserve.rs and expanded with new Cosmos-SDK chain reserved fees.
  • Simplified ReferralFees Structure: The evm_bridge field was removed from the ReferralFees struct, streamlining the structure and consolidating EVM referral logic under a single evm field.
  • Updated Imports and References: Numerous files across the swapper crate were updated to reflect the new module structure and import paths for fee-related types and constants, ensuring consistency with the refactored architecture.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant refactoring by centralizing all fee-related logic, including ReferralFee, ReferralFees, DEFAULT_SWAP_FEE_BPS, DEFAULT_CHAINFLIP_FEE_BPS, DEFAULT_STABLE_SWAP_REFERRAL_BPS, DEFAULT_REFERRER, and slippage calculation functions, into a new fees module. This improves modularity and organization within the swapper crate. The evm_bridge field has been removed from the ReferralFees structure, simplifying its design and usage. Additionally, new chains have been added to the RESERVED_NATIVE_FEES list, and some constant calculations have been replaced with their explicit values for clarity. Overall, these changes enhance the maintainability and structure of the codebase.

@0xh3rman 0xh3rman merged commit 98e5ec8 into main Mar 19, 2026
6 checks passed
@0xh3rman 0xh3rman deleted the refactor-swap-referral branch March 19, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant