Skip to content

Refactor map_account_summary_aggregate to use idiomatic iterator methods #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gemcoder21 merged 2 commits into from
Mar 16, 2026
Merged

Refactor map_account_summary_aggregate to use idiomatic iterator methods #1012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88d4f48
Initial plan
Copilot Mar 15, 2026
e86cc9e
Refactor map_account_summary_aggregate to use iterator methods
Copilot Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions crates/gem_hypercore/src/provider/perpetual_mapper.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,19 +177,14 @@ pub fn map_account_summary(positions: &AssetPositions) -> PerpetualAccountSummar
}

pub fn map_account_summary_aggregate(positions: &[AssetPositions]) -> PerpetualAccountSummary {
let mut account_value = 0.0;
let mut total_ntl_pos = 0.0;
let mut total_margin_used = 0.0;
let mut unrealized_pnl = 0.0;

for positions in positions {
account_value += positions.margin_summary.account_value.parse::<f64>().unwrap_or(0.0);
total_ntl_pos += positions.margin_summary.total_ntl_pos.parse::<f64>().unwrap_or(0.0);
total_margin_used += positions.margin_summary.total_margin_used.parse::<f64>().unwrap_or(0.0);
for position in &positions.asset_positions {
unrealized_pnl += position.position.unrealized_pnl.parse::<f64>().unwrap_or(0.0);
}
}
let account_value: f64 = positions.iter().map(|p| p.margin_summary.account_value.parse().unwrap_or(0.0)).sum();
let total_ntl_pos: f64 = positions.iter().map(|p| p.margin_summary.total_ntl_pos.parse().unwrap_or(0.0)).sum();
let total_margin_used: f64 = positions.iter().map(|p| p.margin_summary.total_margin_used.parse().unwrap_or(0.0)).sum();
let unrealized_pnl: f64 = positions
.iter()
.flat_map(|p| &p.asset_positions)
.map(|p| p.position.unrealized_pnl.parse().unwrap_or(0.0))
.sum();

let account_leverage = if account_value > 0.0 { total_ntl_pos / account_value } else { 0.0 };
let margin_usage = if account_value > 0.0 { total_margin_used / account_value } else { 0.0 };
Expand Down