Add preferInputAsFeeToken for Okx

[0xh3rman]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the referral fee handling within the Okx swapper integration. It introduces a sophisticated logic to intelligently decide whether the input or output token should be used for referral fee payments, prioritizing native assets and stablecoins. This enhancement provides greater flexibility and optimization in how referral fees are managed during swaps.

Highlights

• Referral Fee Logic Enhancement: Introduced a new mechanism to dynamically determine whether referral fees should be paid using the input token or the output token for Okx swaps.
• New toTokenReferrerWalletAddress Field: Added toTokenReferrerWalletAddress to the SwapParams interface, allowing referral addresses to be specified for the destination token.
• Preferred Fee Token Identification: Implemented isPreferredFeeToken and preferInputAsFeeToken utility functions to identify native assets or USD-pegged tokens as preferred for fee payment.
• Updated Okx Provider Logic: Modified the Okx provider to utilize the new referral fee logic, ensuring the correct referrer wallet address (input or output) is applied based on token preference.
• Comprehensive Test Coverage: Added new test cases to validate the toTokenReferrerWalletAddress functionality and the isPreferredFeeToken logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• packages/swapper/src/okx/models.ts
  • Added toTokenReferrerWalletAddress to the SwapParams interface.
• packages/swapper/src/okx/provider.test.ts
  • Updated imports to include SOLANA_USDC_MINT.
  • Added a test case to verify toTokenReferrerWalletAddress is set when the toToken is native.
  • Updated an existing test to assert toTokenReferrerWalletAddress for EVM swaps.
• packages/swapper/src/okx/provider.ts
  • Imported preferInputAsFeeToken.
  • Introduced referrerWalletAddresses function to determine and return the appropriate referrer wallet address based on token preference.
  • Updated buildSwapParams to use the new referrerWalletAddresses function for setting referrer wallet addresses.
• packages/swapper/src/referrer.test.ts
  • Added a new test file to validate the isPreferredFeeToken utility function with various asset types.
• packages/swapper/src/referrer.ts
  • Imported AssetId and QuoteRequest types.
  • Added isPreferredFeeToken function to check if an asset is a preferred fee token (native or USD-pegged).
  • Added preferInputAsFeeToken function to determine if the input token should be preferred for fee payment based on asset types.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces logic to select the referrer fee token for OKX swaps, preferring native tokens or stablecoins. The implementation is mostly correct, but there is a bug in the isPreferredFeeToken function that will cause one of the new tests to fail. I've provided a suggestion to fix this.