Skip to content

Add Base chain config; bump dev dependencies#114

Merged
0xh3rman merged 2 commits intomainfrom
okx-base
Mar 11, 2026
Merged

Add Base chain config; bump dev dependencies#114
0xh3rman merged 2 commits intomainfrom
okx-base

Conversation

@0xh3rman
Copy link
Collaborator

Add support for the Base chain by adding its default RPC URL and OKX chain index mapping. Bump developer tooling versions (@types/node, knip, oxfmt, oxlint) to their newer releases. Also updated pnpm lockfile to reflect those dependency changes.

Add support for the Base chain by adding its default RPC URL and OKX chain index mapping. Bump developer tooling versions (@types/node, knip, oxfmt, oxlint) to their newer releases. Also updated pnpm lockfile to reflect those dependency changes.
@semanticdiff-com
Copy link

semanticdiff-com bot commented Mar 11, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  pnpm-lock.yaml  53% smaller
  apps/api/package.json  0% smaller
  package.json  0% smaller
  packages/swapper/src/chain/evm/jsonrpc.ts  0% smaller
  packages/swapper/src/okx/constants.ts  0% smaller

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates support for the Base blockchain by adding its necessary network configurations, enabling interaction with this new chain. Concurrently, it updates several key development dependencies to their latest versions, ensuring the project benefits from improved tooling, performance, and security patches.

Highlights

  • Base Chain Support: Configuration for the Base blockchain was added, including its default RPC URL and OKX chain index mapping.
  • Developer Dependency Updates: Several developer dependencies, specifically @types/node, knip, oxfmt, and oxlint, were updated to their newer releases.
  • pnpm Lockfile Synchronization: The pnpm-lock.yaml file was updated to reflect all dependency changes, ensuring consistent builds.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • apps/api/package.json
    • Updated @types/node dependency from 25.3.0 to 25.4.0.
  • package.json
    • Updated knip from 5.85.0 to 5.86.0.
    • Updated oxfmt from 0.35.0 to 0.37.0.
    • Updated oxlint from 1.50.0 to 1.52.0.
  • packages/swapper/src/chain/evm/jsonrpc.ts
  • packages/swapper/src/okx/constants.ts
    • Added the chain index '8453' for the Base chain.
  • pnpm-lock.yaml
    • Synchronized various dependency versions to reflect updates in package.json.
    • Updated @types/node and its transitive dependencies across multiple packages.
    • Updated oxc-resolver, oxfmt, and oxlint binding versions.
    • Removed obsolete argparse@2.0.1 and js-yaml@4.1.1 entries.
    • Added new entries for unbash@2.2.0 and yaml@2.8.2, likely due to transitive dependency resolution for knip.
Activity
  • No specific human activity (comments, reviews) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the Base chain by providing its RPC URL and OKX chain index. It also updates several development dependencies to their newer versions. The changes for adding Base chain support seem correct, but I've pointed out a potential omission where a gas limit for Base is not defined for EVM swaps, which could lead to transaction failures. The dependency updates are straightforward.

Note: Security Review did not run due to the size of the PR.

@0xh3rman 0xh3rman merged commit 223aed1 into main Mar 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant