Conversation
|
this is in work in the "geoyear" branch. I corrected the syntax, but there are a few test failures for me to fix in a Matlab < R202b compatible way |
dc865fb to
b3fa50a
Compare
5e03543 to
36c579a
Compare
605e083 to
bc69dd0
Compare
eb89a35 to
c7f5617
Compare
|
Let me know if you want this updated to be merged |
4f9464f to
cc13997
Compare
7458707 to
9a2c94f
Compare
733e12b to
90e77d6
Compare
|
@scivision I think we also need to adjust the code that reads in the config.nml file and grabs the flag that is supposed to toggle this vs. leaving the default values of 11,289. It is described here: https://github.com/gemini3d/gemini3d/blob/main/docs/Readme_input.md in the namelist &magpole. We'd want to also add this feature to PyGemini to maintain parity with matgemini. |
|
Regarding backward compatibility, I think we need to have this default to the original pole location if the namelist to change that is not present. That probably will resolve the CI issues. We also probably need to add some code to default to the original pole location if the user inputs a year that is out-of-range and wants to have the pole adjusted. |
geomag2geog.m, geog2geomag.m and those which are calling them are adjusted for the specification of the YEAR variable that defines coefficients for the transformation of coordinates.
geomag2geog.m, geog2geomag.m (and all other) have additional variable "year" now. If not specified - it is set up as 1985 (default).