Add results endpoint to download a static html file#10
Add results endpoint to download a static html file#10Hendrejvr wants to merge 9 commits intogematik:mainfrom
Conversation
Hendrejvr
changed the title
cybernop
left a comment
cybernop
left a comment
There was a problem hiding this comment.
Would you format all files using black from the recommanded extensions?
|
And what was the reason for you to create a fork for working on the changes instead of creating a simple branch? |
cybernop
left a comment
cybernop
left a comment
There was a problem hiding this comment.
Please also rebase on the latest state of main to enforce checks
I did not have the necessary rights, so I was forced to create a fork |
cybernop
left a comment
cybernop
left a comment
There was a problem hiding this comment.
Have to validate some information
cybernop
left a comment
cybernop
left a comment
There was a problem hiding this comment.
Please fix the type mismatch and also remove commented out code :)
cybernop
left a comment
cybernop
left a comment
There was a problem hiding this comment.
Could you fix the small detail i commented? The rest looks good :)
| if not self.__projs: | ||
| path = self.projs_dir | ||
| if path.is_dir() and (path / "config.json").exists(): | ||
| try: | ||
| self.__projs[path.name] = Project(path) | ||
| except ValidationError as e: | ||
| logger.error(e.errors()) | ||
| raise e | ||
|
|
There was a problem hiding this comment.
Please make sure the this only accepts a directory where the projects are placed like before. Handling a single project for the CLI should be handled differently.
Maybe you can skip the ProjectManager completely and just use a project directly.
2 participants
This pull request creates a new endpoint that returns the mapping structure as a static html page.
The function that generates the html file has also been migrated to the new data model.