Fix everyone role mention #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces utility methods for mentioning "everyone" and "here" in KMarkdown and plain text formats, refactoring existing role mention logic to use these centralized methods for improved consistency and maintainability.
- Added four new utility methods to
MentionUtilsfor "everyone" and "here" mentions - Refactored
RestRoleandSocketRoleclasses to use the new utility methods instead of hardcoded strings
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Kook.Net.Core/Utils/MentionUtils.cs | Added KMarkdownMentionEveryone(), KMarkdownMentionHere(), PlainTextMentionEveryone(), and PlainTextMentionHere() utility methods with proper documentation |
| src/Kook.Net.Rest/Entities/Roles/RestRole.cs | Updated KMarkdownMention and PlainTextMention properties to use new utility methods for "everyone" role |
| src/Kook.Net.WebSocket/Entities/Roles/SocketRole.cs | Updated KMarkdownMention and PlainTextMention properties to use new utility methods for "everyone" role |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds utility methods for mentioning "everyone" and "here" in both KMarkdown and plain text formats, and refactors existing role mention logic to use these new methods for consistency and maintainability.
Mention Utility Enhancements
KMarkdownMentionEveryone()andKMarkdownMentionHere()methods toMentionUtilsfor generating KMarkdown-formatted mentions of all members and online members.PlainTextMentionEveryone()andPlainTextMentionHere()methods toMentionUtilsfor generating plain text mentions of all members and online members.Role Entity Refactoring
RestRole.KMarkdownMentionandRestRole.PlainTextMentionto use the new mention utility methods when the role is "everyone", improving consistency and code reuse.SocketRole.KMarkdownMentionandSocketRole.PlainTextMentionto use the new mention utility methods for "everyone" mentions, ensuring standardized output across implementations.