Fix SSOv2 HttpClient null bug, remove pointless try-catches, minor code quality#166
Draft
Fix SSOv2 HttpClient null bug, remove pointless try-catches, minor code quality#166
Conversation
…ity improvements Co-authored-by: gehnster <7077730+gehnster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review repository for potential improvements and issues
Fix SSOv2 HttpClient null bug, remove pointless try-catches, minor code quality
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several issues identified during codebase review — ranging from a silent null-assignment bug to noise code patterns.
Bug:
SSOv2._httpClientnever assigned when caller provides a clientAdditionally,
_httpClientwasstatic, meaning allSSOv2instances shared one client — a second instantiation would silently overwrite it. Changed to an instance field.Code quality
try { ... } catch (Exception) { throw; }blocks inAPIBase.RequestAsyncandAPIBase.ProcessSuccess— they re-throw unchanged with no side effects.TRANQUILITY_ESI_BASE/SERENITY_ESI_BASEpromoted from mutablestaticfields toconst.CheckAuthwas throwingnew ArgumentNullException()with no message or parameter name; replaced withArgumentExceptioncarrying a descriptive message covering all validated inputs.<PackageLicenseUrl></PackageLicenseUrl>removed from.csproj— deprecated and already superseded by the existing<PackageLicenseExpression>.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.