Switch to Microsoft.IdentityModel.JsonWebTokens#163
Merged
gehnster merged 1 commit intogehnster:masterfrom Feb 23, 2026
Merged
Conversation
System.IdentityModel.Tokens.Jwt is described as "As of IdentityModel 7x, this is a legacy tool that should be replaced with Microsoft.IdentityModel.JsonWebTokens.", and Microsoft.IdentityModel.JsonWebTokens is described as "This is a newer, faster version of System.IdentityModel.Tokens.Jwt that has additional functionality."
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SSOv2 access-token parsing/validation implementation to use Microsoft.IdentityModel.JsonWebTokens instead of System.IdentityModel.Tokens.Jwt, aligning token validation with the newer IdentityModel handler APIs.
Changes:
- Replaced
JwtSecurityTokenHandlerusage withJsonWebTokenHandlerinSSOv2.GetCharacterDetailsAsync. - Updated claim extraction to use
TokenValidationResult.ClaimsIdentity/SecurityToken. - Swapped NuGet dependency from
System.IdentityModel.Tokens.JwttoMicrosoft.IdentityModel.JsonWebTokens.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| EVEStandard/SSOv2.cs | Migrates token validation and claim extraction to JsonWebTokenHandler APIs. |
| EVEStandard/EVEStandard.csproj | Replaces the JWT package dependency with Microsoft.IdentityModel.JsonWebTokens. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests all ran fine, tested this in my project by replacing the lib with a local .nupkg i built and everything seems to work fine for me. Lemme know if you want any changes, or just do em yourself if theyre small, edits by maintainers are enabled!