Skip to content

Raise error that can be handled by try/except #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rhijjawi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Raise error that can be handled by try/except #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7062dd
Update core.py
rhijjawi Jul 19, 2021
e944aca
Update core.py
rhijjawi Jul 19, 2021
64f4249
Update core.py
rhijjawi Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions PyDictionary/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def translate(self, term, language):
word = gs.translate(term, language)
return word
except:
print("Invalid Word")
raise InvalidWord

def getSynonyms(self, formatted=True):
return [self.synonym(term, formatted) for term in self.args]
Expand Down Expand Up @@ -97,7 +97,7 @@ def synonym(term, formatted=False):
@staticmethod
def antonym(term, formatted=False):
if len(term.split()) > 1:
print("Error: A Term must be only a single word")
raise TooManyWords
else:
try:
data = _get_soup_object("https://www.synonym.com/synonyms/{0}".format(term))
Expand All @@ -108,12 +108,12 @@ def antonym(term, formatted=False):
return {term: antonyms}
return antonyms
except:
print("{0} has no Antonyms in the API".format(term))
raise NoResults

@staticmethod
def meaning(term, disable_errors=False):
if len(term.split()) > 1:
print("Error: A Term must be only a single word")
raise TooManyWords
else:
try:
html = _get_soup_object("http://wordnetweb.princeton.edu/perl/webwn?s={0}".format(
Expand All @@ -135,7 +135,7 @@ def meaning(term, disable_errors=False):
return out
except Exception as e:
if disable_errors == False:
print("Error: The Following Error occured: %s" % e)
raise e
Copy link

@rudiejd rudiejd Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what type of exceptions would get raised here? is it possible to raise other named exceptions in this block?

Copy link
Author

@rhijjawi rhijjawi Sep 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just saw this, I haven't been on GitHub in a while. Depends on the error in the Exception. If anyone knows the complete list of errors thrown by this exception, go ahead and list them here.


if __name__ == '__main__':
d = PyDictionary('honest','happy')
Expand Down