API v2

[romeo-delta]

Good Afternoon, I am working on a project using coinspot API and I needed V2 API calls. I noticed that you had not had the time to update this to v2 so I thought I would jump in and help out.

Description

• This change is an implementation of the CoinSpot API v2 functionality. It implements all of the API calls listed by CoinSpot.
• this fixes issue (Support for API V2  #20)
• This change also implements the requests library, instead of using httplib / client
• this fixes issue (coinspot.py httplib Python 3 Deprecated #18) and (investigate switching to requests library instead of httplib #10)

Features

• [1] New Feature - Added CoinSpot v2 Functionality
• [2] New Feature - Switched to requests library
• [3] Breaking change - this removes all of the old functions. There is no backward compatability due to changing the names of the functions.
• [4] Documentation - These changes require a documentation update

How Has This Been Tested?

This has been locally tested, no test cases have been created yet.

Remarks

• There are a couple of things:
  • For optional parameters I have used **kwargs, since there weren't default values for every optional parameter.
  • Naming convention for the Read Only API are named like my_function (example my_withdrawhistory). This follows the same convention used in the CoinSpot documentation.
  • I scraped the docstrings directly from the CoinSpot documentation
  • The public API uses a GET and the private API a POST. I split these up into two different method, _request and _request_public.

[geekpete]

This looks based off master branch, have you checked out the fixes that went into the py3fixes branch? I was intending to update master with this newer branch. But also Thank You! for submitting this PR! We can probably try to get both of these two major changes merged into master if possible.

[romeo-delta]

Yeah it is from the master branch, I didn't notice the py3fixes. I'll have a look and see if I can merge them

[geekpete]

Thanks for looking into it.
I think I need to get those py3 fixes merged back into the main branch as soon as I can get some time to do so...