You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's a good start, but there are some loose ends that need to be tidied up before merging the pull
I can merge and then clean it up when I have time, or you can take a look at it yourself.
Making all of your names and modes capitalizes violates the style of the original data set and makes consistent integration and updating much more difficult when some things are capitalized and some things are not. For example, the default data.js actually has a resource item called 'bread' which already has an icon, but it's not actually used in the game. You could easily refer to that instead of defining a new 'Bread' resource.
Making grain and flour part of food means that they are getting eaten raw instead of being turned into bread. You can put them in the food category for display but not "partof:food" to treat them as just an ingredient.
The settings button doesn't do anything if you don't add it as a requirement for the technologies and the modes (add "'enablebread':'on' to the req list for the various elements), and you will want to use my convertUnitMode function to change modes on any existing units (eg if you have 5 artisans grinding when you turn the option off, you need to change their mode to something else otherwise they will keep going with a mode that shouldn't even be available).
Similarly, I would move the addition of grain gathering to the callback function when the setting is turned on, and delete the gathering mode when turning the setting off. The idea is, if the setting is disabled, then the game should look and play exactly like it did if the mod were not even there.
If I have time, I'll look at making these changes and testing before merging into the master. Thanks for contributing!
You might want to add a policy to disable eating raw grain since it tastes so bad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the code. I am not sure that it will work at all, but it is at least a try.