Skip to content

RFE: In lockfile, include UID, and add FQDN to hostname #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pwa0202 wants to merge 57 commits into
base: master
Choose a base branch
from
Open

RFE: In lockfile, include UID, and add FQDN to hostname #1

pwa0202 wants to merge 57 commits into from

Conversation

@pwa0202
Copy link

@pwa0202 pwa0202 commented Mar 5, 2016

Based on CPAN ticket 112723

Have you considered the possible enhancement to File::NFSLock of including the UID (or full domain name?) of the locker in the *.NFSLock file?

In my usage of this module I would find that to be a useful addition to the lock file...

Perhaps this info is not there thoughtfully, e.g. maybe there are security/privacy considerations that I'm overlooking - if so I'd be interested to hear about them.

hookbot and others added 30 commits May 29, 2014 14:19
@hookbot
Import File::NFSLock 1.21 stock from CPAN
971c1aa
@hookbot
Update test files to match version 1.21
2277730
Bump to version 1.22
02b16d3
@hookbot
Cosmetic changes to pod
db8929c 
 - README
 - lib/File/NFSLock.pm
@hookbot
Merge branch 'master' of ssh://github.com./hookbot/File-NFSLock
7b4df66
@hookbot
Version 1.22
c953c71 
Fix RT#86125
@hookbot
Bump version 1.23
1c004cc
@hookbot
More graceful handle crazy hostnames with weird regex meta characters…
9f52f96 
… in it.
@hookbot
RT#84658 discovered and reported and patch by Yann Rouillard:
c81fad8 
Avoid gleefully double removing possibly valid lockfile when ->unlock is explicitly called and then DESTROY is implicity called.
@hookbot
Patch RT#84658 by Yann Rouillard:
f570006 
Avoid gleefully double removing valid lockfile when ->unlock is explicitly called.
@hookbot
Revision 1.23
69ffbb6
@hookbot
Version 1.23
fa7d019
@hookbot
Bump version 1.24
7dcabaa
@hookbot
Bump version 1.24
f8b5f3c
@hookbot
RT#88520 Thanks David Steinbrunner: Fix typos
84d5f8d
@hookbot
RT#88520 Thanks David Steinbrunner: Fix typos
dab7a16
@hookbot
Fix RT#61258
280b5a9
@hookbot
Fixed race condition to prevent a newly acquired lock from being prem…
e567d53 
…aturely released by the crashed lock detection cleanup process.
@hookbot
Version 1.24
0a0c166
@hookbot
Bump version to 1.25
425bce5
@wchristian
fix tempfile usage in tests to actually get the temp filename, instea…
ffbd042 
…d of writing to "GLOB(...)" in CWD
@wchristian
on windows files open by a process have mandatory locks, so they cann…
296f663 
…ot be deleted before the handles are closed
@hookbot
Merge pull request #1 from wchristian/win32_fixes
1b51662 
win32 fixes
@hookbot
Fix tempfile syntax
d416c25
@hookbot
It's fairly safe to close the file handle before removing since the l…
f3922e6 
…ock_file has been already exclusive locked using File::NFSLock

This allows it to be more compatible with Win32 perl.
@hookbot
RT#42122
34ce863 
Add tests with TAINT enabled.
@hookbot
RT#48102
54e7a09 
Testing fork()ing with a Shared Lock.
@hookbot
RT#42122
6d174ff 
Add tests with TAINT enabled.
@hookbot
RT#48102
be84831 
Update tests to reflect new fork behavior.
@hookbot
RT#48102
a57ed39 
Update documentation to reflect the new newpid() behavior for fork()
Mention github repo
hookbot and others added 27 commits November 7, 2014 13:07
@hookbot
Close Version 1.25
ac1d82f
@hookbot
Bump to version 1.26
b2190c9
@hookbot
Implement #1 and #2 suggestions explained in RT#48102
644fbaa 
Make ->newpid method convert itself into a Shared Lock within both parent and child.
@hookbot
Add tests to ensure parent still holds the lock after fork()ing for R…
feeb53e 
…T#48102.
@hookbot
Add File::NFSLock->fork() convenience method.
9e3b965
@hookbot
Add tests to test the new ->fork() method functionality.
0fc13c2
@hookbot
Version 1.26
51ec138
@hookbot
Bump to Version 1.27
d6bc157
@hookbot
Bump to version 1.27
f55b020
@hookbot
RT#99431
63d38d6 
Compatibility fixes in test suite for Win32 Perl.
@hookbot
RT#48102
43134e5 
Add tests to test the new ->fork() method functionality.
@hookbot
Version 1.27
6791f2f
@hookbot
Bump to Version 1.28
70b5a4b
Ignore MYMETA.json generated file.
89b87e2
Handle "." not in @inc on new-fangled Perl versions.
4a4be6b
Version 1.28
8fd46c7
@toddr
Add travis-ci to File-NFSLock commits.
d555bc5
Bump to Version 1.29 to signify PAUSE
75a6809
@hookbot
Merge pull request #4 from toddr/master
ee92739 
Add travis-ci support
Hiding PERL_USE_UNSAFE_INC to test Travis-CI
f9bb80d
Get rid of crusty old deprecated PERL_USE_UNSAFE_INC setting.
9b539ec
For Perl 2.26 and higher, prevent this crashing spewage:
0500977 
do "Makefile.PL" failed, '.' is no longer in @inc; did you mean do "./Makefile.PL"? at File-NFSLock.spec.PL line 32.
Makefile.PL: Missing WriteMakefile at File-NFSLock.spec.PL line 36.
make: *** [File-NFSLock.spec] Error 2
For Perl 2.26 and higher, prevent this crashing spewage:
1bb8b85 
do "lib/File/NFSLock.pm" failed, '.' is no longer in @inc; did you mean do "./lib/File/NFSLock.pm"? at (eval 1) line 2.
No version! at File-NFSLock.spec.PL line 41.
make: *** [File-NFSLock.spec] Error 2
Version 1.29
f48b0f8
Version 1.29
6efd615
Happy New Year
83bf81c
Happy New Year
ee115a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pwa0202 @hookbot @wchristian @toddr