decrypt: Attempt to use a NewGCM() without specifying nonce and tag size before bailing.#27
Closed
IsaacG wants to merge 1 commit intogearnode:masterfrom
Closed
decrypt: Attempt to use a NewGCM() without specifying nonce and tag size before bailing.#27IsaacG wants to merge 1 commit intogearnode:masterfrom
NewGCM() without specifying nonce and tag size before bailing.#27IsaacG wants to merge 1 commit intogearnode:masterfrom
Conversation
… size before bailing.
Owner
|
Thanks for all your patches! For this one, could you provide more context on when this case would occur? Go versions prior to 1.23 should never reach this code path, so I’d like to better understand the scenario. |
Contributor
Author
My personal and work PC are both running go 1.24.5. Does that help? I'm not seeing a |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code fails to decrypt messages from privatebin.net and private (unnamed) sites tested.
Using
cipher.NewGCM(block)successfully decrypts messages from said sites. It may not always work, but it certainly works in more scenarios with more privatebin sites.