Skip to content

Fix camera vertical movement to use local up vector #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdtknight merged 1 commit into from
Mar 27, 2026
Merged

Fix camera vertical movement to use local up vector #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/input/input_camera.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,14 @@ static void camera_rebuild_dir(t_camera *cam)
void handle_camera_move(t_render *render, int keycode)
{
t_vec3 right;
t_vec3 up;
t_vec3 move;
double step;

step = 1.0;
right.x = -cos(render->scene->camera.yaw);
right.y = 0;
right.z = sin(render->scene->camera.yaw);
right = (t_vec3){-cos(render->scene->camera.yaw), 0,
sin(render->scene->camera.yaw)};
up = vec3_normalize(vec3_cross(right, render->scene->camera.direction));
if (keycode == KEY_W)
move = vec3_multiply(render->scene->camera.direction, step);
else if (keycode == KEY_X)
Expand All @@ -53,9 +54,9 @@ void handle_camera_move(t_render *render, int keycode)
else if (keycode == KEY_D)
move = vec3_multiply(right, step);
else if (keycode == KEY_Q)
move = (t_vec3){0, step, 0};
move = vec3_multiply(up, step);
else if (keycode == KEY_Z)
move = (t_vec3){0, -step, 0};
move = vec3_multiply(up, -step);
else
return ;
render->scene->camera.position = vec3_add(render->scene->camera.position,
Expand Down
Loading