fix grating coupler simulation #539
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzhangflex
reviewed
Mar 27, 2025
| # Define Gaussian beam source | ||
| gaussian_beam = td.GaussianBeam( | ||
| size=(td.inf, td.inf, 0), | ||
| size=(fiber_mfd, td.inf, 0), |
There was a problem hiding this comment.
The source size is a bit small, I would recommend using at least 2x fiber_mfd, 3x would be even better.
bzhangflex
reviewed
Mar 27, 2025
| waveguide_port_center = [xy_shifted[0], xy_shifted[1], (size_z) / 2] | ||
| waveguide_port_center = [-sim_size[0] / 2 + port_waveguide_offset, 0, 0] | ||
|
|
||
| waveguide_monitor = td.ModeMonitor( |
There was a problem hiding this comment.
The main issue I found while testing this was that the mode monitor z span was too large. The mode monitor was extending into the si substrate, which caused the monitor to overlap for slab modes instead of waveguide modes. I would recommend setting the default values (eg zmargin=0) so that the monitor doesn't extend into the substrate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #538
However the results from the simulation didn't seem correct
@momchil-flex
@yaugenst