pullFeat benchmark script final fix #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit provides the final fix for the semi-automated benchmark script. It corrects the `--os-variant` parameter in the `virt-install` command from 'ubuntu22.04' to 'ubuntu24.04' to match the downloaded Ubuntu 24.04 cloud image. This resolves the "Unknown OS name" error and should allow the KVM virtual machine to be created successfully. The script is now considered complete and robust for the semi-automated workflow.
This commit delivers the definitive version of the semi-automated benchmark script for Grid'5000. It resolves all previously identified issues through extensive debugging, resulting in a robust and platform-aware solution. The script now requires the user to manually reserve nodes and provide their hostnames as arguments. It then automates the entire remaining workflow, correctly handling: - Grid'5000's two-hop SSH proxy. - The platform-specific `sudo-g5k` command for administrative tasks. - KVM/`virt-install` quirks by removing the problematic `--os-variant` flag and correctly formatting the `--disk size` parameter. - A complete test loop with robust error handling, logging, and automated cleanup of all created resources.
This commit introduces a new benchmark case for the `student-server` Spring Boot application. Modifications: - `students-server/.../StudentsController.java`: The controller has been updated to include request forwarding logic. It now accepts an optional `machine` parameter to redirect `/getstudent` and `/getrecord` requests to a backend server, enabling a 3-tier architecture test. - `run_g5k_benchmark.sh`: The main benchmark script has been updated to include a new test loop for the `student-server` application. It now handles the upload of two versions of the application's WAR file (standard and ODB-transformed) and runs performance tests comparing them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.