Add PokePatch feature with Retrofit and Coil integration#94
Conversation
mariobodemann
left a comment
mariobodemann
left a comment
There was a problem hiding this comment.
Very fancy!
I disagree with the build.gradle changes, but otherwise only has few minute things.
Does it come with an embroidery machine to test?
converter/build.gradle.kts
Outdated
| if (!pythonPath.isNullOrBlank()) { | ||
| buildPython(pythonPath) | ||
| } else { | ||
| val osName = System.getProperty("os.name").lowercase() |
There was a problem hiding this comment.
I don't think that's an assumption we should make here. If the path is not set, assume default installation, otherwise insist on ZE_PATH. Soooooooooo, can we not have the os things?
There was a problem hiding this comment.
I did all the changes on windows machine...
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| enableEdgeToEdge() | ||
| SingletonImageLoader.setSafe { context -> |
There was a problem hiding this comment.
😱
And the documentation said, it's not needed if we do nothing special...
There was a problem hiding this comment.
I'll check again there was an error and after this one it was ok
| ) | ||
|
|
||
| interface PokeApi { | ||
| @GET("pokemon?limit=20&offset=0") |
There was a problem hiding this comment.
We probably should set a higher limit. Maybe 1400? Or page through the results, but then we need to expose the offset...
(all the Pokemon!!)
There was a problem hiding this comment.
I decreased for faster loading. However, if you like I can adjust to 1400
| var mons by remember { mutableStateOf(listOf<Mon>()) } | ||
| var mon by remember { mutableStateOf<Mon?>(null) } | ||
| var error by remember { mutableStateOf<String?>(null) } | ||
| var isLoading by remember { mutableStateOf(false) } |
| shouldCapture = shouldCapture, | ||
| onBitmap = onBitmap, | ||
| ) { | ||
| when { |
There was a problem hiding this comment.
I don't get why this is nicer then just a bunch of ifs, but sure.
| ) | ||
| } | ||
| ) { | ||
| Text(text = pokemon.name.replaceFirstChar { it.uppercaseChar() }) |
…vity initialization, and increase pokemon fetch limit to 1400
mariobodemann
left a comment
mariobodemann
left a comment
There was a problem hiding this comment.
Will this be the last change on this repository?? Maybe!
Who knows, we will see 🙌 |
2 participants
No description provided.