See my issue #26, these are my fixes from my v1.1 at https://codeberg.org/gargle/tumblesocks. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d replaced the original code with these small modifications. It seems to work now.
…arch-forward-regexp "^$" nil t) into (search-forward-regexp "^{" nil t) add (previous-line) tumblesocks-api-process-response
…og-post-at-point are in my first pull request too. this pull request includes work on the json response as well' (gcr#2) from gargle/tumblesocks:fix3 into fix Reviewed-on: https://codeberg.org/martianh/tumblesocks/pulls/2
…a tumblesocks-view-notifications function
…a tumblesocks-view-notifications function
…ead of 4, and no more changes to the face
…now in the new tumblr web interface)' (gcr#3) from gargle/tumblesocks:fix into fix Reviewed-on: https://codeberg.org/martianh/tumblesocks/pulls/3
and some explaining about tumblesocks-view-notifications.
The full url of the image
…mblesocks:fix into fix Reviewed-on: https://codeberg.org/martianh/tumblesocks/pulls/4
…ations' (gcr#7) from gargle/tumblesocks:fix into fix Reviewed-on: https://codeberg.org/martianh/tumblesocks/pulls/7
… gargle/tumblesocks:fix into fix Reviewed-on: https://codeberg.org/martianh/tumblesocks/pulls/8
…/tumblesocks:fix into fix Reviewed-on: https://codeberg.org/martianh/tumblesocks/pulls/9
…nd tumblesocks-view-notifications' (gcr#4) from fix into master Reviewed-on: https://codeberg.org/gargle/tumblesocks/pulls/4
…cks:master into master Reviewed-on: https://codeberg.org/martianh/tumblesocks/pulls/11
…uld appear twice and use the locale for the date and time of the notifications.' (gcr#13) from gargle/tumblesocks:master into master Reviewed-on: https://codeberg.org/martianh/tumblesocks/pulls/13
…notifications' (gcr#14) from gargle/tumblesocks:master into master Reviewed-on: https://codeberg.org/martianh/tumblesocks/pulls/14
…e of posting in local time
…macs.d/ directory. oauth is using oauth-t--create and oauth-access-token--create now
…rt # before '(lambda to get rid of some warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forked https://codeberg.org/martianh/tumblesocks into https://codeberg.org/gargle/tumblesocks and made some changes to your code to make it work with oauth again. I also changed the layout, added #tags to posts, and I added a 'tumblesocks-view-notifications'. I added a copyright comment in tumblesocks.el, tumblesocks-api.el, and tumblesocks-view.el with my handle 'gargle' and I added myself as an 'author' in tumblesocks.el.
Everything seems to work so I tagged my changes as v1.1 and 'released' them on codeberg.org. I merged my changes in the master branch of https://codeberg.org/martianh/tumblesocks. I was under the impression that https://codeberg.org/martianh/tumblesocks was the new canonical repository, but I am wrong, am I not?
Let me know if you agree/disagree with those copyright messages. I'd like to see my changes appear in the offical elpa repository. Tell me if I have to change anything.
I already discovered some mistakes in my work and am already on version 1.1.5. This pull request has all of my changes, including the fixes.