Skip to content

Replace absolute timing assertion with relative comparison #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcomte merged 1 commit into from
Mar 30, 2026
Merged

Replace absolute timing assertion with relative comparison #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/currency/fiat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,19 @@ mod tests {
fn test_exchange_rate_caching() {
let start = Instant::now();

// First call should take a while.
// First call fetches from the API.
let btc_value = Fiat::USD.btc_value();
let elapsed_first_call = start.elapsed().as_micros();
let elapsed_first_call = start.elapsed();
assert!(btc_value > 0.0);
assert!(elapsed_first_call > 1000);

// Second call should be fast (even when looking up another fiat currency).
// Second call should use cached data and be much faster.
let start2 = Instant::now();
let btc_value = Fiat::EUR.btc_value();
let elapsed_second_call = start2.elapsed();
assert!(btc_value > 0.0);
assert!(start.elapsed().as_micros() - elapsed_first_call < 1000);
assert!(
elapsed_second_call < elapsed_first_call / 10,
"Second call ({elapsed_second_call:?}) should be much faster than first ({elapsed_first_call:?})"
);
}
}
Loading