Update CI: replace archived actions, enforce clippy, pin linelint

.github/workflows/build.yml

@@ -16,11 +16,8 @@ jobs:
     name: Build and Test
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: rust-toolchain
-        uses: actions-rs/toolchain@v1.0.6
-        with:
-          toolchain: stable
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
       - name: Build
         run: cargo build --verbose
       - name: Run unit tests

.github/workflows/code-analysis.yml

@@ -13,11 +13,8 @@ jobs:
     name: Security audit
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: rust-toolchain
-        uses: actions-rs/toolchain@v1.0.6
-        with:
-          toolchain: stable
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
       - name: Install security audit
         run: cargo install cargo-audit
       - name: Run security audit
@@ -26,45 +23,37 @@ jobs:
     name: Check code formatting
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: rust-toolchain
-        uses: actions-rs/toolchain@v1.0.6
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
         with:
-          toolchain: stable
           components: rustfmt
       - name: Check code formatting
         run: cargo fmt --check --all
   clippy_check:
     name: Clippy check
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: rust-toolchain
-        uses: actions-rs/toolchain@v1.0.6
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
         with:
-          toolchain: stable
           components: clippy
       - name: Clippy
-        run: cargo clippy --all-targets
+        run: cargo clippy --all-targets -- -D warnings
   linelint:
     name: Check that files end with line break
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Linelint
-        uses: fernandrone/linelint@master
+        uses: fernandrone/linelint@0.0.6
         id: linelint
   unused_dependencies:
     name: Look for unused dependencies
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: rust-toolchain
-        uses: actions-rs/toolchain@v1.0.6
-        with:
-          toolchain: nightly
-          override: true
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@nightly
       - name: Install unused dependency checker
         run: cargo install cargo-udeps
       - name: Run unused dependency checker

src/defaults.rs

@@ -54,7 +54,7 @@ impl Defaults {
             "Reading contents of file {} --> input amount: {}, input currency: {}, output currencies: [{}]",
             config.path().display(),
             defaults.amount,
-            defaults.input_currency.to_string(),
+            defaults.input_currency,
             defaults
                 .output_currencies
                 .iter()

tests/int_tests.rs

@@ -71,7 +71,7 @@ fn test_amount_input_validation() {
     let si_suffix = "1M";
     cmd.args(vec![&si_suffix, "SAT", "BTC"])
         .assert()
-        .stdout(format!("0.01 BTC\n"));
+        .stdout("0.01 BTC\n".to_string());
 
     // Allow using floating point numbers
     let mut cmd = cargo::cargo_bin_cmd!("bitcoinvert");