Skip to content

Fix argument accumulation bug in integration test#499

Merged
gcomte merged 1 commit intomasterfrom
fix/integration-test-arg-accumulation
Mar 30, 2026
Merged

Fix argument accumulation bug in integration test#499
gcomte merged 1 commit intomasterfrom
fix/integration-test-arg-accumulation

Conversation

@gcomte
Copy link
Copy Markdown
Owner

@gcomte gcomte commented Mar 30, 2026

Summary

  • test_different_amount_of_arguments reused a single Command, causing .args() to accumulate. The "1 argument" case actually ran with 1 arg, "2 arguments" with 2, and "3 arguments" with 3 — only by accident.
  • Split into 4 independent tests, each with a fresh Command.

Test plan

  • cargo test --test int_tests passes

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Warning

Rate limit exceeded

@gcomte has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 18 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 13 minutes and 18 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6c2f4b01-3535-403f-b5c0-31b784a6c6fb

📥 Commits

Reviewing files that changed from the base of the PR and between abaa207 and 738773d.

📒 Files selected for processing (1)
  • tests/int_tests.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/integration-test-arg-accumulation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The test reused a single Command, causing args to accumulate across
cases. Each argument-count scenario now uses a fresh Command.
@gcomte gcomte force-pushed the fix/integration-test-arg-accumulation branch from b3efd12 to 738773d Compare March 30, 2026 06:59
@gcomte gcomte merged commit 045f586 into master Mar 30, 2026
7 checks passed
@gcomte gcomte deleted the fix/integration-test-arg-accumulation branch March 30, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant