Skip to content

Bump MSRV from 1.61.0 to 1.88.0#497

Merged
gcomte merged 1 commit intomasterfrom
fix/update-msrv
Mar 30, 2026
Merged

Bump MSRV from 1.61.0 to 1.88.0#497
gcomte merged 1 commit intomasterfrom
fix/update-msrv

Conversation

@gcomte
Copy link
Copy Markdown
Owner

@gcomte gcomte commented Mar 30, 2026

Summary

  • Dependencies already require Rust 1.88.0+ (verified via cargo msrv find). The declared MSRV of 1.61.0 was inaccurate.

Test plan

  • cargo check passes
  • CI build passes

Summary by CodeRabbit

  • Chores
    • Updated the minimum supported Rust version requirement to 1.88.0.

Dependencies already require 1.88.0+ (verified via cargo-msrv).
The declared MSRV of 1.61.0 was inaccurate and misleading.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

📝 Walkthrough

Walkthrough

The minimum supported Rust version (MSRV) in Cargo.toml has been updated from 1.61.0 to 1.88.0. This adjustment reflects the crate's compatibility with newer Rust toolchains and may enable the use of language features introduced in those intermediate versions.

Changes

Cohort / File(s) Summary
Rust Version Update
Cargo.toml
Bumped minimum supported Rust version from 1.61.0 to 1.88.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version bump hops into view,
From sixty-one to eighty-eight we flew!
Rust grows stronger, so do we,
Modern features now are free,
The compiler's path shines bright and new! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the minimum supported Rust version (MSRV) from 1.61.0 to 1.88.0, which is the only modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/update-msrv

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Cargo.toml (1)

7-7: Consider adding MSRV verification to CI.

While the MSRV update is correct, the CI workflows currently test against stable and nightly toolchains but not the declared minimum version. This means the MSRV guarantee isn't verified in CI—if code inadvertently uses features from Rust > 1.88.0, it won't be caught until someone tries to build with the minimum version.

Consider adding a CI job that builds and tests with Rust 1.88.0 to ensure the MSRV claim remains accurate:

msrv_check:
  name: Check MSRV
  runs-on: ubuntu-latest
  steps:
    - uses: actions/checkout@v2
    - name: rust-toolchain
      uses: actions-rs/toolchain@v1.0.6
      with:
        toolchain: 1.88.0
        override: true
    - name: Check
      run: cargo check --all-features

As per coding guidelines, the workflows .github/workflows/code-analysis.yml and .github/workflows/build.yml use toolchain: stable which does not verify the MSRV of 1.88.0 declared in Cargo.toml.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Cargo.toml` at line 7, Add an MSRV verification job to CI so the declared
rust-version = "1.88.0" in Cargo.toml is actually tested: add a workflow job
(e.g., msrv_check) in your existing GitHub Actions workflows (such as
.github/workflows/code-analysis.yml or build.yml) that sets the toolchain to
1.88.0 (using actions-rs/toolchain@v1 or actions-rs/toolchain@v1.0.6) with
override: true and runs cargo check --all-features (or cargo test) to fail CI if
the code requires a newer Rust than the rust-version field; ensure the job name
and steps reference the MSRV explicitly so the CI verifies the Cargo.toml
rust-version.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Cargo.toml`:
- Line 7: Add an MSRV verification job to CI so the declared rust-version =
"1.88.0" in Cargo.toml is actually tested: add a workflow job (e.g., msrv_check)
in your existing GitHub Actions workflows (such as
.github/workflows/code-analysis.yml or build.yml) that sets the toolchain to
1.88.0 (using actions-rs/toolchain@v1 or actions-rs/toolchain@v1.0.6) with
override: true and runs cargo check --all-features (or cargo test) to fail CI if
the code requires a newer Rust than the rust-version field; ensure the job name
and steps reference the MSRV explicitly so the CI verifies the Cargo.toml
rust-version.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4f3ffc39-736d-47c5-9759-07638ef0c08e

📥 Commits

Reviewing files that changed from the base of the PR and between 18dbe11 and 925399c.

📒 Files selected for processing (1)
  • Cargo.toml

@gcomte gcomte merged commit 6fdec08 into master Mar 30, 2026
7 checks passed
@gcomte gcomte deleted the fix/update-msrv branch March 30, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant