This repository was archived by the owner on Feb 16, 2021. It is now read-only.
Open
Conversation
Author
|
I guess |
Author
5e6ff99 to
db5e170
Compare
db5e170 to
2342b5f
Compare
d3cc40b to
57cc7a5
Compare
Author
|
So, probably we want to have |
Author
|
I think we can decrease the bundle size more. Seems Webpack creates smaller bundles than Bili. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This replaces Webpack with Bili (a bundler based on Rollup).
Main reason is that I want to use tcomb on ObservableHQ (for notebook-based programming) via unpkg.com. It currently only includes CommonJS bundles and the
dist/directory is missing: (see: https://unpkg.com/tcomb@3.2.29/).I've added/modified entries in
package.json(which seems a sane default) to let unpkg.com and jsdelivr.com know where to find the bundles. Adapted from https://github.com/immerjs/immer/blob/v3.1.1/package.json. Theumd:mainoutput is minified for use in browsers.It adds a
bili.config.tswhere you can e.g. configure the formats. The apidocs (https://bili.egoist.sh/api/globals.html#format) say you can additionally use"cjs-min" | "es-min" | "esm-min" | "umd-min" | "iife-min" | "amd-min" | "system-min". Adapted from https://github.com/immerjs/immer/blob/v3.1.1/bili.config.ts.Finally I've changed
package.jsonscripts to havebuildandtest. I think unpkg.com needs it to process the bundles and put it intodist/for each release. I've runnpm run buildandnpm run testand it works. Do we want to add both steps to.travis.yml?I've also tested microbundle but Bili was better documented and configurable. Not relevant for tcomb bundle process but worth mentioning: It also does not leave annoying build cache directories used by
rollup-plugin-typescript2(this can be also configured). Alsoiifeoutput option is documented and does not clash withcjsoutput configuration like in microbundle. Bili is much smaller than microbundle (see "Bili vs Microbundle" issue at egoist/bili#163).